Skip to content

fix: return empty raster instead of failing when viewport has no reef data #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ConnectedSystems merged 1 commit into from
Aug 2, 2026
Merged

fix: return empty raster instead of failing when viewport has no reef data #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 4 additions & 23 deletions src/job_worker/handlers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,18 +621,8 @@ function handle_job(
)
@info "Done setting up scoped regional assessment data"

# Guard: if the scope doesn't intersect any reef data, fail with a clear message
# rather than crashing inside assess_region_quality.
scoped_slope_table = regional_data.regions[input.region].slope_table
if nrow(scoped_slope_table) == 0
throw(
ErrorException(
"No reef data found within the requested scope for region '$(input.region)'. " *
"Try selecting a larger area or an area that overlaps with known reef data."
)
)
end
@info "Scoped slope table has $(nrow(scoped_slope_table)) rows"
scoped_row_count = nrow(regional_data.regions[input.region].slope_table)
@info "Scoped slope table has $(scoped_row_count) rows (0 = no reef data in viewport)"

@info "Compiling regional assessment parameters from regional data and input data"
params = build_regional_assessment_parameters(
Expand Down Expand Up @@ -699,17 +689,8 @@ function handle_job(
)
@info "Done setting up scoped regional assessment data"

# Guard: if the scope doesn't intersect any reef data, fail with a clear message.
scoped_slope_table = regional_data.regions[input.region].slope_table
if nrow(scoped_slope_table) == 0
throw(
ErrorException(
"No reef data found within the requested scope for region '$(input.region)'. " *
"Try selecting a larger area or an area that overlaps with known reef data."
)
)
end
@info "Scoped slope table has $(nrow(scoped_slope_table)) rows"
scoped_row_count = nrow(regional_data.regions[input.region].slope_table)
@info "Scoped slope table has $(scoped_row_count) rows (0 = no reef data in viewport)"

@info "Compiling suitability assessment parameters from regional data and job inputs"
params::ReefGuide.SuitabilityAssessmentParameters = build_suitability_assessment_parameters(
Expand Down
Loading