Improvements - #11
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Drop Julia 1.11 support outright per the ReefGuide.jl 1.12 migration: bump the julia compat bound, re-resolve the manifest, and update the Docker base images (runtime and sysimage builder), CI image-publish workflow, and README setup instructions accordingly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…lock The bare `catch` left `e` unbound, and `region_metadata` was never defined in this function's scope at all (only `region_id` is a parameter) - so any failure threw a masking UndefVarError instead of the real underlying exception, on the live per-job region-load path used by every suitability-assessment job needing an uncached region. Also adds a minimal Test-based test/ suite (previously nonexistent) exercising this fix. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
`-t auto` derives the thread pool size from whatever CPU count Julia observes on the host cgroup, not the ECS task's actual CFS quota/vCPU allocation - a classic Fargate over-provisioning trap at fractional/low vCPU allocations. Pin it explicitly via JULIA_NUM_THREADS instead, so it can be set to match the task definition's real vCPU allocation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
They are dev-only tools and must not end up baked into the production sysimage. Also fix sandbox/start.sh to cd into its own directory first so it works regardless of the caller's cwd. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ReefGuide.jl 0.2.0 carries the #5, #6, #7, #4b fixes and the Julia 1.12 migration. Registration is in flight; Manifest.toml will be re-resolved once it's available (currently still pinned to the last resolvable 0.1.12 to keep Pkg.instantiate() working in the meantime). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades ReefGuideWorker.jl to Julia 1.12 (dropping 1.11 support) and picks up the corresponding fixes from ReefGuide.jl 0.2.0, alongside a couple of worker-side reliability and deployment fixes.
prepare_target_regional_data: a barecatchleft the exception unbound and referenced aregion_metadatavariable that was never defined in this function, so any failure on the per-job region-load path surfaced as an opaqueUndefVarErrorinstead of the real underlying error. Also adds atest/suite (there wasn't one before) covering this.JULIA_NUM_THREADSexplicitly instead of relying on-t auto, which reads the host cgroup's CPU count rather than the ECS task's actual vCPU allocation — a common source of thread over-provisioning on Fargate at fractional/low vCPU allocations.ReefGuidecompat bound to 0.2.0, which carries the unbound-catch-block fix, the suitability-threshold scale bug fix, thefilter_sitesoverlap-detection fix, and a type-instability fix in the assessment hot path.