Harden code-scanning hotspots in process invocation and wildcard expansion#629
Draft
Harden code-scanning hotspots in process invocation and wildcard expansion#629
Conversation
Copilot
AI
changed the title
[WIP] Fix issues reported in code scanning
Harden code-scanning hotspots in process invocation and wildcard expansion
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the code-scanning findings by removing shell-style argument construction from Docker-based test helpers and by rejecting traversal-style roots during code analysis wildcard expansion.
Process execution hardening
ProcessStartInfo(..., "arg1 arg2 ...")usage with tokenizedArgumentListconstruction in Docker-related test fixtures.Wildcard expansion hardening
..) before filesystem enumeration when expanding--code-analysis-resultspatterns.Regression coverage
WildcardExpander.Checklist
Merge method: Use Rebase and merge to maintain a linear history. The repository enforces rebase-only merges by default.
Create & merge guidance: Use
scripts/pr-github.sh createto create PRs, andscripts/pr-github.sh create-and-mergeto perform the merge (this script is the authoritative, repo-preferred tool for PR creation and merges). If you need to inspect/check the PR, use GitHub chat tools (github/*) as needed.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.