Repository navigation
Upgrade to OWL API 5 - #1295
Draft
jamesaoverton wants to merge 4 commits into
Draft
Upgrade to OWL API 5#1295jamesaoverton wants to merge 4 commits into
jamesaoverton wants to merge 4 commits into
Conversation
jamesaoverton
commented
Oct 7, 2026
| */ | ||
| @Nonnull | ||
| @Override | ||
| public Stream<OWLOntology> ontologies() { |
Member
Author
There was a problem hiding this comment.
This method is required to implement HasGetOntologies.
jamesaoverton
commented
Oct 7, 2026
jamesaoverton
commented
Oct 7, 2026
balhoff
pushed a commit
to owlcollab/expression-materializing-reasoner
that referenced
this pull request
Oct 20, 2026
Same OWL API version as ROBOT (ontodev/robot#1295). Depends on owlapi-api and owlapi-impl (OWLReasonerBase moved there in v5) instead of owlapi-distribution. Test reasoners moved to ELK 0.6.0 and HermiT 1.4.5.519, Java target to 11. test1 now asserts against expected-superclasses-over.tsv, recorded with OWL API 4.2.5 before the upgrade; all 244 inferences match.
This was referenced Oct 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Protégé project is upgrading to OWL API 5.5.1 and we want ROBOT to stay in sync. protegeproject/protege#1351
Here is the OWL API migration guide.
The code is compiling and the unit tests are passing, with the exception of some now marked
@Ignored (see below). The command line integration tests are not yet passing.Done:
Optionaltojava,utl.Optional.or()withorElse().orNull()with.orElse(null).orElseThrow(...)EntitySearcherstreams back into collections by adding.collect(Collectors.toList())owlexplanationto 5.0.1 and make minor API changes*PrefixOWLOntologyFormatto*PrefixOWLDocumentFormatSet<_>withStream<_>, and replace.size()with.count()ReferencedEntitySetProviderand replace withontology.getSignature(Imports.INCLUDED)try/catchwhen certain exceptions can no longer be thrown, e.g.RioRendererno longer throwsIOExceptionOntologyHelper.getObjects(OWLAxiom)togetAxiomObjects(OWLAxiom), avoiding an ambiguity withgetObjects(OWLOntology)-- this breaks ourjapicmpbackwards compatibility checks, but I don't think it can be helpedOWLOntologyLoaderConfigurationwithOntologyConfiguratorowl-diff@balhoff -- many of our tests rely on diffs, and these are all disabled for nowTo Do:
obographsfor some JSON formats @matentznextract subset(specifically scowl?) @balhofforg.geneontology.reasoner.ExpressionMaterializingReasonerFactoryfrom https://github.com/owlcollab/expression-materializing-reasoner @matentznMeasureOperation@matentzn@Ignoretestsjapicmptests for backwards compatibility