FLO-18: rename perSecondInterestRate to use nominal label#260
Open
FLO-18: rename perSecondInterestRate to use nominal label#260
Conversation
Co-authored-by: Gornutz <90406700+Gornutz@users.noreply.github.com>
Co-authored-by: Gornutz <90406700+Gornutz@users.noreply.github.com>
Co-authored-by: Gornutz <90406700+Gornutz@users.noreply.github.com>
Co-authored-by: Gornutz <90406700+Gornutz@users.noreply.github.com>
Co-authored-by: Gornutz <90406700+Gornutz@users.noreply.github.com>
Co-authored-by: Gornutz <90406700+Gornutz@users.noreply.github.com>
…-rate-terminology
docs: clarify nominal interest rate semantics
ad94e24 to
4699e83
Compare
Contributor
|
For clarity, the current final state of this PR is broader than the original description. What this branch now does:
Files touched in the final branch state:
Validation run on this branch:
So the net effect is: terminology/documentation cleanup, one explicit helper for effective annual yield in the constant-rate case, and no intended change to protocol economics. |
Gornutz
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #227
Addresses FLO-18. The per-second rate uses linear (nominal) decomposition (r / secondsPerYear), which means exponential compounding produces an effective APY that exceeds the stated rate. Rather than changing the behavior, this PR clarifies the semantics:
Renames perSecondInterestRate(yearlyRate:) → perSecondInterestRate(nominalYearlyRate:) to make the nominal nature explicit
Adds effectiveYearlyRate(nominalYearlyRate:) view function computing (1 + r/n)^n - 1