FLO-20: eliminate per-position capability controller bloat#247
Open
FLO-20: eliminate per-position capability controller bloat#247
Conversation
jordanschalm
approved these changes
Mar 10, 2026
holyfuchs
force-pushed
the
holyfuchs/FLO-20-createPosition-storage-bloat
branch
from
87ad2e1 to
a56de6a
Compare
Member
Author
|
creation of FlowALPPositionResources.cdc on main required a rewrite |
jordanschalm
approved these changes
Mar 12, 2026
| access(all) fun depositCapacity(from: auth(FungibleToken.Withdraw) &{FungibleToken.Vault}) { | ||
| if let pool = self.pool.borrow() { | ||
| pool.depositAndPush( | ||
| if let pool = FlowALPPositionResources.poolCap?.borrow() { |
Member
There was a problem hiding this comment.
Kind of weird that this doesn't bind the non-nil pool value inside the conditional block. I guess because there is an optional operation on poolCap first. Almost seems like a Cadence bug, though -- I feel like the if..let statement should only consider the value assigned to pool.
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #229
Replace per-position capabilities.storage.issue() calls with a contract-level _borrowPool() that directly borrows the Pool from storage. Position, PositionSink, and PositionSource no longer hold a Capability field — they call the contract function directly — so no new CapabilityController is created per position.