Repository navigation
tagging: decide a narrowed link again for the lane that reads it - #9993
Merged
Merged
Conversation
A save decides a mention's link over every person in a world the turn is in, readable or not, and vault.tagging.tags serves that link narrowed to the persons a lane reads. Three tests pin what a member outside a relationship is served for a name whose saved link names a person only that relationship's members read: - a lone readable sound-alike beside the hidden person: today served as candidates naming the readable one; the lane's own decision mints, so it is served as unmatched, and its mentions leave the turn out; - the hidden person's exact name: today served as a tag; served as unmatched; - the exact name beside two readable sound-alikes: today served as a tag; served as candidates naming those two. A member of that relationship is served the saved link (control). FIX TAG-LINK-DECIDED-OVER-UNREADABLE-PERSONS, lead ruling A (21 Nov).
vault.tagging.tags and vault.tagging.mentions served a saved mention's
link with the entities the lane cannot read taken out. The save decides
that link over every person in a world the turn is in, so a narrower lane
learned that a person it cannot read is there: one holding the mention's
exact name left a tag where the lane alone would mint, and one that
sounds like the name turned a lone sound match into candidates.
Under the Engine's rule of 2026-10-15 (ARCH-0067:367, a contact the
reader cannot read counts as absent; lead ruling A of 21 Nov), a link
that names an entity the lane does not read is now decided again for
that lane, by the save's own arms and rungs in the save's order, over the
entities it reads: the key's hits, the role rung over the edges and
persons it reads, the phonetic rung with its two-hit cut, then the saved
identity hint and the vector order under the lane's read. Nothing is
written. Where the save would mint, the lane is served the new view
state MentionLinkView::Unmatched { kind }. Every other link is served as
stored. A link taken from outside the turn (a context or speaker
reference), and one whose antecedent the lane does not see, keep
today's narrowing.
vault.tagging.mentions serves a hit with the same lane link and leaves
out a hit whose lane link no longer names the asked entity.
The stored link and every reader of it inside the engine are unchanged.
Stored change: none (MentionLinkView gains a variant; RESOLUTIONS stores
views built from the stored link only, which never hold it).
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
|
Warning Review limit reached
This review includes 6 billable files and costs up to $1.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 42 minutes for your next included review. View limit details
|
vault.tagging.mentions reads a hit, then the turn's lane view in a later snapshot. A re-tag between the two reads can move the set's indices, so a hit whose index names another span in the view is left out rather than served with that span's link (own review P3-2 of the lane decision).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX row [TAG-LINK-DECIDED-OVER-UNREADABLE-PERSONS] (P2). Lead ruling A (21 Nov): apply the Engine's rule of 2026-10-15 ("a contact the reader cannot read counts as absent", ARCH-0067:367): the link is decided again for the lane over the persons it reads, only when narrowing removed one.
What changes
A save decides each mention's link over every person in a world the turn is in, readable or not.
vault.tagging.tagsserved that link with the entities the lane cannot read taken out, so a narrower lane learned that a person it cannot read is there: a hidden person holding the mention's exact name left a tag where the lane alone would mint, and a hidden person who sounds like the name turned a lone sound match into candidates.tagging/save/lane.rs:lane_links_in_txnserves each shown mention's stored link while it names only entities the lane reads (a provisional entity shows with its mention, as before). A link that names one the lane does not read is decided again for that lane, by the save's own arm for the mention and the save's rungs in the save's order, over what the lane reads: the key's hits, the role rung over the edges and persons it reads, the phonetic rung with its two-hit cut, then the saved identity hint and the vector order under the lane's read (HintRead::Caller). Role edges are read at the set'ssaved_at. Nothing is written.MentionLinkView::Unmatched { kind }(oneiron-verb-wire): no entity of that kind that the reader reads matches the span. (Sub-choice ASK TAG-LINK-UNMATCHED-VIEW, recommendation A; option B, a tag, is one match arm intagging_tags.)vault.tagging.mentionsserves each hit with the same lane link (lane_hit_link) and leaves out a hit whose lane link no longer names the asked entity, before the limit counts.role_rungis taken out ofLinker::role_linkso the save and the lane's role rung share it; the save's behaviour is unchanged.Stored change: none.
MentionLinkViewgains a variant; RESOLUTIONS (identity/evidence.rs) stores views built from stored links only, which never hold it, and its erase scan treats it as naming no entity.Test
RUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test tag_link_lane_decision(crates/oneiron/tests/tag_link_lane_decision.rs). Kathryn Smith is confirmed from a name only a relationship R's MESSAGE holds; the outsider is a member of S only, the insider of both; the TURN under test is one S MESSAGE.a_hidden_sound_alike_leaves_the_outsider_an_unmatched_name_not_one_candidate: with a readable Katherine Smith, "Katharine Smyth" is saved as candidates naming both; main serves the outsider candidates naming Katherine Smith (and lists the mention under her); the head serves it unmatched and lists no mention of her. The insider is served both (control).a_hidden_exact_name_leaves_the_outsider_an_unmatched_name_not_a_tag: "Kathryn Smith" is saved as candidates naming her alone; main serves the outsider a tag, the head serves it unmatched. The insider is served her (control).a_hidden_exact_name_leaves_the_outsider_the_sound_alikes_it_reads: with readable Katherine Smith and Kathrin Smith, main serves a tag, the head serves candidates naming those two.The served link is compared as its JSON, so the file builds on main. Red pin:
opus-fixpick-a/tag-link-decided-per-lane-red(main c8a36a0 + the test file).