Skip to content

tagging: decide a narrowed link again for the lane that reads it - #9993

Merged
olety merged 3 commits into
mainfrom
opus-fixpick-a/tag-link-decided-per-lane
Nov 20, 2026
Merged

olety merged 3 commits into
mainfrom
opus-fixpick-a/tag-link-decided-per-lane

Conversation

@olety

@olety olety commented Nov 20, 2026

Copy link
Copy Markdown
Member

FIX row [TAG-LINK-DECIDED-OVER-UNREADABLE-PERSONS] (P2). Lead ruling A (21 Nov): apply the Engine's rule of 2026-10-15 ("a contact the reader cannot read counts as absent", ARCH-0067:367): the link is decided again for the lane over the persons it reads, only when narrowing removed one.

What changes

A save decides each mention's link over every person in a world the turn is in, readable or not. vault.tagging.tags served that link with the entities the lane cannot read taken out, so a narrower lane learned that a person it cannot read is there: a hidden person holding the mention's exact name left a tag where the lane alone would mint, and a hidden person who sounds like the name turned a lone sound match into candidates.

  • New tagging/save/lane.rs: lane_links_in_txn serves each shown mention's stored link while it names only entities the lane reads (a provisional entity shows with its mention, as before). A link that names one the lane does not read is decided again for that lane, by the save's own arm for the mention and the save's rungs in the save's order, over what the lane reads: the key's hits, the role rung over the edges and persons it reads, the phonetic rung with its two-hit cut, then the saved identity hint and the vector order under the lane's read (HintRead::Caller). Role edges are read at the set's saved_at. Nothing is written.
  • Where the save would mint, the lane is served the new view state MentionLinkView::Unmatched { kind } (oneiron-verb-wire): no entity of that kind that the reader reads matches the span. (Sub-choice ASK TAG-LINK-UNMATCHED-VIEW, recommendation A; option B, a tag, is one match arm in tagging_tags.)
  • A link taken from outside the turn (a context or speaker reference) keeps today's narrowing: the tag set keeps no coordinates of the earlier span. So does a mention whose antecedent the lane does not see, so no decision rests on words the lane does not read.
  • vault.tagging.mentions serves each hit with the same lane link (lane_hit_link) and leaves out a hit whose lane link no longer names the asked entity, before the limit counts.
  • role_rung is taken out of Linker::role_link so the save and the lane's role rung share it; the save's behaviour is unchanged.
  • The stored link, the save, and every reader of the stored link inside the engine (re-check, settlement, sieve, relation extraction) are unchanged. No verb row changes; no grant is added (the two verbs keep their Read scope and the caller's own lane).

Stored change: none. MentionLinkView gains a variant; RESOLUTIONS (identity/evidence.rs) stores views built from stored links only, which never hold it, and its erase scan treats it as naming no entity.

Test

RUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test tag_link_lane_decision (crates/oneiron/tests/tag_link_lane_decision.rs). Kathryn Smith is confirmed from a name only a relationship R's MESSAGE holds; the outsider is a member of S only, the insider of both; the TURN under test is one S MESSAGE.

  • a_hidden_sound_alike_leaves_the_outsider_an_unmatched_name_not_one_candidate: with a readable Katherine Smith, "Katharine Smyth" is saved as candidates naming both; main serves the outsider candidates naming Katherine Smith (and lists the mention under her); the head serves it unmatched and lists no mention of her. The insider is served both (control).
  • a_hidden_exact_name_leaves_the_outsider_an_unmatched_name_not_a_tag: "Kathryn Smith" is saved as candidates naming her alone; main serves the outsider a tag, the head serves it unmatched. The insider is served her (control).
  • a_hidden_exact_name_leaves_the_outsider_the_sound_alikes_it_reads: with readable Katherine Smith and Kathrin Smith, main serves a tag, the head serves candidates naming those two.
    The served link is compared as its JSON, so the file builds on main. Red pin: opus-fixpick-a/tag-link-decided-per-lane-red (main c8a36a0 + the test file).

A save decides a mention's link over every person in a world the turn is
in, readable or not, and vault.tagging.tags serves that link narrowed to
the persons a lane reads. Three tests pin what a member outside a
relationship is served for a name whose saved link names a person only
that relationship's members read:

- a lone readable sound-alike beside the hidden person: today served as
  candidates naming the readable one; the lane's own decision mints, so
  it is served as unmatched, and its mentions leave the turn out;
- the hidden person's exact name: today served as a tag; served as
  unmatched;
- the exact name beside two readable sound-alikes: today served as a
  tag; served as candidates naming those two.

A member of that relationship is served the saved link (control).
FIX TAG-LINK-DECIDED-OVER-UNREADABLE-PERSONS, lead ruling A (21 Nov).
vault.tagging.tags and vault.tagging.mentions served a saved mention's
link with the entities the lane cannot read taken out. The save decides
that link over every person in a world the turn is in, so a narrower lane
learned that a person it cannot read is there: one holding the mention's
exact name left a tag where the lane alone would mint, and one that
sounds like the name turned a lone sound match into candidates.

Under the Engine's rule of 2026-10-15 (ARCH-0067:367, a contact the
reader cannot read counts as absent; lead ruling A of 21 Nov), a link
that names an entity the lane does not read is now decided again for
that lane, by the save's own arms and rungs in the save's order, over the
entities it reads: the key's hits, the role rung over the edges and
persons it reads, the phonetic rung with its two-hit cut, then the saved
identity hint and the vector order under the lane's read. Nothing is
written. Where the save would mint, the lane is served the new view
state MentionLinkView::Unmatched { kind }. Every other link is served as
stored. A link taken from outside the turn (a context or speaker
reference), and one whose antecedent the lane does not see, keep
today's narrowing.

vault.tagging.mentions serves a hit with the same lane link and leaves
out a hit whose lane link no longer names the asked entity.

The stored link and every reader of it inside the engine are unchanged.
Stored change: none (MentionLinkView gains a variant; RESOLUTIONS stores
views built from the stored link only, which never hold it).
@greptile-apps

greptile-apps Bot commented Nov 20, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 6 billable files and costs up to $1.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 42 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 152 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c8a36a0 and f565161.

Files selected for processing: 6

  • crates/oneiron-verb-wire/src/tagging/verbs.rs
  • crates/oneiron/src/dreamer_runner/maintenance/identity/evidence.rs
  • crates/oneiron/src/tagging/save.rs
  • crates/oneiron/src/tagging/save/lane.rs
  • crates/oneiron/src/tagging/verbs.rs
  • crates/oneiron/tests/tag_link_lane_decision.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

vault.tagging.mentions reads a hit, then the turn's lane view in a later
snapshot. A re-tag between the two reads can move the set's indices, so
a hit whose index names another span in the view is left out rather than
served with that span's link (own review P3-2 of the lane decision).
@olety
olety merged commit 61a9ca2 into main Nov 20, 2026
11 checks passed
@olety
olety deleted the opus-fixpick-a/tag-link-decided-per-lane branch November 20, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant