Repository navigation
Conversation
…ead (red) [D19-GATE-COUNTS-CLAIMS-THE-DISCLOSURE-CLAMP-REFUSES]: a proposed claim the pack's audience may not read (Tier A) counts in claims_suppressed and makes an empty clamped pack read AllActivated, for a bounded text or vector fetch (a claim search) and for a list that reaches the blend unasked. Guards: a proposed claim the audience may read still counts, and a live hidden claim still counts among the pack's clamped rows.
[D19-GATE-COUNTS-CLAIMS-THE-DISCLOSURE-CLAMP-REFUSES]: in a pack clamped for an audience, a row the audience could not read whatever its status (DisclosureContext::admits_row_ignoring_status) is now kept from every check that records a refusal in the run, so a dead claim it may not read counts in no claims_suppressed and leaves the empty reason as it is: - the shared fetch admission asks the clamp's own-row test before the entity-type authority and the D19 gate record anything; - the text channel's gate-widening probe treats such a posting as no posting of the run, as it treats a device-local one (its rejections join the gate); - a ranked list no bounded fetch asked (an unnarrowed vector, text or temporal list) drops such a row before the blend, as the phonetic code rung does since #9911, so it takes no rank and counts as no candidate in scope; one that meets every other check, judged in caches of its own, still counts among the pack's clamped rows. A pack with no clamp is unchanged.
…in-scope count An empty clamped pack reports the rows it surfaced as its candidates in scope, never the pre-clamp count the owner's pack reports, so the guard for a proposed claim the audience may read compares the empty reason and the suppressed claims only.
|
Warning Review limit reached
This review includes 17 billable files and costs up to $4.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 57 minutes for your next included review. View limit details
|
…gate reaches A context pack runs in the memory lane, which narrows its vector walk in caches of its own whose rejections never join the run, so a pack's vector search never counted a hidden claim and its tests stopped at the owner's fixture. The text channel reaches the gate both ways: a claim search's bounded fetch, and an unnarrowed search's widening probe and fused union. The fixture asks the clamp of a hidden claim served as a live revision (Tier A, not its status, hides it), and the guards search text only.
…l records Review of #9980: the clamp's own-row test ran before the cheap checks that record nothing (types, times, codebase, criticality), so a clamped scan paid it for every posting. It now runs only where a refusal would be recorded: at the entity-type authority's refusal and just before the D19 gate. The verdict is unchanged. The per-list step's doc names the lists it meets: a pack's vector walk is narrowed to its memory lane.
olety
marked this pull request as ready for review
November 20, 2026 19:32
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
…window or temporal cut REVIEW-9980 round 1: proposed claims the audience may not read that outrank a readable proposed claim filled the unnarrowed text scan's window and the temporal channel's cut, and left the lists only before the blend, so the clamped pack read NoData with no suppression where it read AllActivated with one. A guard keeps a live hidden claim of an unnarrowed temporal list among the pack's clamped rows.
…den rows no place REVIEW-9980 round 1. The clamp's own-row test ran only before the blend, so rows the audience could not read whatever their status still took places in the unnarrowed fetches: hidden claims that outranked a readable one filled the memory lane's text window (category BM25) or the temporal channel's window, scan caps and cut, and the readable row never reached the run. The pack then read NoData with no suppression where it read AllActivated. - Text: the memory lane's category read asks the clamp after the lane, so a hidden row takes no place in its window. - Temporal: the clamp joins the channel's reader (the scope, then the made_by slice), so a hidden row counts toward no stop and takes no place under a scan's cap or in the bound; a clamped pack's unnarrowed list is then cut as before. - Both hand back the hidden rows that ranked inside the places the read or cut gave them before; the pack counts those that meet every other check among the rows its clamp withheld, as it did when they reached the blend.
…lace in the bound The window cut asks the reader of the row itself, so it never keeps a hidden row, and the count of hidden rows among the cut's rows was always empty: a live hidden claim of an unnarrowed temporal list no longer counted among the pack's clamped rows. The count now walks the rows the bound holds with no reader asked (WindowCut::ranks_inside_bound), best first, in the lane, and takes the hidden ones among the first `limit`.
…ch judged row Review of the round-1 fix (Opus P3): a read that judges past many hidden rows ran with no deadline checkpoint, unlike the scope's admission, which checks in at every candidate. Under a clamp each judged lane row now checks in. Docs say what the owner-side clamped count takes on the pending-walk text read and in a temporal window that grows past the one a call without the clamp held.
…l cut counts them REVIEW-9980 round 2. In a clamped pack, hidden proposed claims holding a readable claim's word counted in that word's document frequency, so live claims outranked the readable one and filled the text window: the pack counted no suppressed claim. A made_by slice narrows the temporal list, and its cut handed back no hidden row, so a live hidden claim inside the window counted among no clamped rows. The text helpers now blend no recency, as both reviews' scenarios read: with the blend, the text window holds 320 rows, not 80.
…c, and a narrowed temporal cut hands them back REVIEW-9980 round 2. - BM25: under a clamp, a term's document frequency counts only the postings of rows the audience could read (a live hint's claim, or the row itself; a dead hint counts as hidden). The pipeline's text stage and HyDE retry pass the clamp's own-row test through Bm25SearchOptions::hidden_row and TextQuery::hidden_row. Hidden postings still score, for the owner-side count of the rows the clamp withheld; admission keeps them out. The document count and the fields' average lengths stay the vault's. - Temporal: a narrowed list (a scope or a made_by slice) under a clamp hands back the hidden rows that the scope and slice admit inside the bound a reader without the clamp gives (WindowCut::rows_inside_bound_where), among the first limit lane rows, as the unnarrowed list does.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
[D19-GATE-COUNTS-CLAIMS-THE-DISCLOSURE-CLAMP-REFUSES] (P2): in a context pack clamped for an audience, a dead claim the audience may not read (for example a Proposed claim marked Tier A) still counted in
PackStats::claims_suppressedand made an empty pack readAllActivatedin place ofNoData. The audience learned one bit: a claim it may not read matched. The phonetic code rung's half landed with #9911; this PR closes the rest.A row the audience could not read whatever its status (
DisclosureContext::admits_row_ignoring_status, the door #9911 added) is now kept from every check that records a refusal in the run:Shared fetch admission (
pipeline/filters.rs,pipeline_candidate_matches_filters_and_gate): the clamp's own-row test now runs where a refusal would be recorded: at the entity-type authority's refusal and just before the D19 gate. Before, both recorded first and the clamp asked last. The checks that record nothing (types, times, codebase, criticality) still run first. This covers every bounded vector/text/temporal fetch, the media lists and the PPR walk's visibility. The predicate's verdict does not change: the full clamp test with the decoded body still runs after the gate.Text gate-widening probe (
execution/channels/text.rs): such a posting is no posting of the run, the same as a device-local one. FIX 199 imports every probe rejection into the run's gate, so before, a hidden dead claim counted as suppressed through the probe.Lists no bounded fetch asked (
scoped_channels.rsretain_rows_the_clamp_admits, called from the run's per-list step inexecution/channels/mod.rs): an unnarrowed text, HyDE-retry or temporal list held every row it ranked. A hidden row took a fusion rank and counted as a candidate in scope, and the run's D19 gate (inside the first blend and over the fused union) recorded its refusal. Such a row now leaves the list before the blend, as the phonetic code rung's exact hits do since pipeline: ask the call's scope of the phonetic exact hits before the blend #9911. A hidden row that meets every other check of the call is judged in caches of its own and still counts among the pack's clamped rows (disclosure_clamped). The phonetic step and this one share that judgement (meets_every_check_but_the_clamp). (A pack's vector walk is narrowed to the memory lane, in caches of its own whose rejections never join the run, so it never counted a hidden claim.)Fetch windows (REVIEW-9980 round 1): hidden rows that outrank a readable row no longer take its place in a fetch, so the readable row reaches the run.
text.rssearch_text_candidates, for the primary read and the HyDE retry) asks the clamp's own-row test after the lane, so a hidden row takes no place in the BM25 window.scoped_channels.rsscoped_temporal_results, theReadableRowsreader of fix(pipeline): a temporal scan cap asks the reader before it drops a row [TEMPORAL-READER-SCAN-CAP-REFUSED-ROWS] #9968). A hidden row counts toward no stop and takes no place under a scan's cap, in the bound or in the cut. A clamped pack's unnarrowed list now goes through that reader, keeps the cut's readable rows, and is cut to its limit as before.limitplaces, the places a read without the clamp gave them (ChannelAccumulator::clamped_at_fetch). Those that meet every other check count among the clamped rows (count_rows_clamped_at_fetch), soclamped_outkeeps the count it had when they reached the blend.clamp_hides_row(filters.rs) is the one test that sites 2, 3 and 4 share.Behaviour
filters.disclosureis set, andadmits_row_ignoring_statusadmits everything when the context does not clamp.clamped_outwhatever its score. This is the rule the phonetic rung has followed since pipeline: ask the call's scope of the phonetic exact hits before the blend #9911.clamped_outcan now differ from before. This is the owner-side count only: no audience-visible output reads it, andclamped_out_underfilters it.limithidden lane rows it meets rather than the best ranked.clamped_out, on main as on this head. Filed as [CLAMPED-COUNT-MISSES-BOUNDED-FETCH-DROPS].read_suppressedby the per-list type step, on main as on this head. That set feeds scoped-read receipts only, not the pack.limitreadable rows, each a deadline checkpoint as at the scope's admission;This is an estimate by reading, not a measurement.
Stored change: none. No verb, no ABI.
Tests
crates/oneiron/tests/clamp_before_claim_gate.rs, run withRUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test clamp_before_claim_gate:FAILBEFORE D19-CLAMP: a claim search (the bounded fetch, change 1) and an unnarrowed search (the widening probe and the fused union, changes 2 and 3 together).a_clamped_text_search_reads_alike_with_hidden_claims_that_outrank_a_readable_one(FAILBEFORE REVIEW-9980-TEXT-WINDOW): 100 hidden claims matching both words ofcobalt zircon, one readable claim matching one word in a field as long;a_clamped_temporal_search_reads_alike_with_hidden_claims_nearer_its_anchor(FAILBEFORE REVIEW-9980-TEMPORAL-CUT): Occurred mode, 100 hidden claims at the anchor's midpoint, the readable claim half a sigma off it.Red pins: branch
opus-unbuilt3-c/d19-gate-after-clamp-red, which is main plus the round-0 test file (the twoD19-CLAMPtests), and commit7efd5e4f559e, the tests on the pre-fix head (the twoREVIEW-9980tests).Reviews
read_suppressed) are stated above.7efd5e4f559e, fixe5e453e29b31).8b8365489679withWindowCut::ranks_inside_bound; the new temporal guard covers it.8b8365489679: no P1 or P2, and both scenarios are fixed. Its P3s:5abe5e2135fd;truncate_to_scope) dropped hidden rows from a narrowed list before any count.