Skip to content

fix(off_record): a run refused on record because its room keeps its secrets says to save the room (FIX ROOM-CUSTODY-ON-RECORD-CARRY) - #10041

Open
olety wants to merge 4 commits into
mainfrom
opus-fix-custody/room-custody-on-record-carry
Open

olety wants to merge 4 commits into
mainfrom
opus-fix-custody/room-custody-on-record-carry

Conversation

@olety

@olety olety commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

FIX ROOM-CUSTODY-ON-RECORD-CARRY (P3; the Engine's ANSWER 21 Nov 06:19 = A: keep the refusal, fail closed, and make the run's end message say to save the room to keep its secrets). Built on #10004's branch; stack #10005 landed in train 0619, and the base is main.

What was wrong

Since #10003 (REVIEW-10003 round 2), a run an off-record room began, whose record holds a room handle ([secret r<tag>.<n>]), is refused when its stretch went on record and the run's next append, wait resume or owned put would write that record to base: base holds no custody of the value the handle names, and only a save of the room moves it there (the lead's rule: "fingerprint only on save"). The refusal was OffRecordTaintedBaseWrite ("base write rejected: is a live off-record overlay member"), which told the owner nothing about what to do. The run ends with the room.

Change

  • oneiron-contracts error/off_record.rs: new variant OffRecordError::OffRecordRoomSecretsUnsaved { run_ref }, message "run holds secrets its off-record room keeps, so it cannot go on record and ends with the room: a save of the room keeps only the secrets its saved talk names, never one the run alone holds" (REVIEW-10041: a save carries only the room handles its saved rows name, so a secret only the run holds is not kept by a save). Its kind stays ErrorKind::OffRecordTaintedBaseWrite (a base write an off-record room's state refused), so no wire code, classifier or SDK row changes.
  • code_run/storage/routing/replay.rs: refuse_room_bound_record (append, wait resume, owned put) returns the new variant. Nothing else changes: the writer commits nothing, consumes nothing, and a wait stays.

Stored change: none (an error message only).
No new verb, grant or attestation.

Tests

Stem crates/oneiron/tests/room_custody_handle_scope.rs, a_record_holding_a_room_handle_does_not_move_to_base_on_record now also asserts the refusal's message says what a save of the room keeps ("a save of the room keeps only the secrets its saved talk names", "never one the run alone holds") and names the run.
Red at the test commit 6847baa (on #10004's head: the old message) and at the review test commit a7b94e4 (pin opus-fix-custody/room-custody-on-record-carry-review-red, on 1bbc3ab: "save the room to keep its secrets"), green at the head; runs booked in the lane's proof chain.
RUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test room_custody_handle_scope

…secrets says to save the room to keep them (FIX ROOM-CUSTODY-ON-RECORD-CARRY)
…ecrets ends saying to save the room to keep them (FIX ROOM-CUSTODY-ON-RECORD-CARRY)
@greptile-apps

greptile-apps Bot commented Nov 20, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 34 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 152 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 8a3f9f5 and 07302a8.

Files selected for processing: 3

  • crates/oneiron-contracts/src/error/off_record.rs
  • crates/oneiron/src/code_run/storage/routing/replay.rs
  • crates/oneiron/tests/room_custody_handle_scope.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Base automatically changed from opus-fix-custody/room-local-custody-save to main November 20, 2026 21:52
…secrets its saved talk names (REVIEW-10041, FIX ROOM-CUSTODY-ON-RECORD-CARRY)

REVIEW-10041 P1: a save of the room carries only the room handles its
saved rows name, so a secret only the run's record holds is not kept by
saving the room. The run's end message must say what a save keeps: only
the secrets its saved talk names, never one the run alone holds.

On the head 1bbc3ab the message says "save the room to keep its
secrets", so the assertion fails.
…s only the secrets its saved talk names (REVIEW-10041, FIX ROOM-CUSTODY-ON-RECORD-CARRY)

REVIEW-10041 P1: "save the room to keep its secrets" promised more than a
save does. A save carries only the room handles its saved rows name, so a
secret only the run's replay row holds is wiped with the room whether or
not the room is saved. OffRecordRoomSecretsUnsaved now reads "run <run>
holds secrets its off-record room keeps, so it cannot go on record and
ends with the room: a save of the room keeps only the secrets its saved
talk names, never one the run alone holds". The refusal, its kind and
everything it writes or keeps stay as they were.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant