Repository navigation
Conversation
…les near the giant-file bar Move only. llm/step/step_claim.rs (793 lines) keeps the terminal step claim write and the value encoder; the fail-closed value decoder with its decoded form and two helpers moves to the child module step_claim/decode.rs, and its two names stay reachable through step_claim as the memo index names do. dreamer_consolidation/extraction_pack/reads.rs (793 lines) keeps the checked pack, the paging and the read plans; the listed claim row, the eligible pairs, the restatement rule and the cited claims move to the sibling correction_listing.rs. Only module lines, imports, two visibility paths and the new module docs differ from the moved text. FIX [LENT-PACK-FILES-NEAR-GIANT-FILE-BAR].
…nder Test support only. The verdict parity fixture lends its role tables a sourced route beside the scripted backend: a call that names the rows its input was read from goes to the same backend, and the route keeps those rows. A test reads them with take_bound_source_rows, or through the step fixture with fixture_step_bound_source_rows. The four role tables built on the fixture (the verdict lender, the native oracle's executor, the shared pass resources and the step lender) take the route; a call that names no complete set sends as before and leaves no entry.
A native decision read sends on its route bound to the rows fixed code read its input from, so the call's permit, its receipt and its model-call row name them (FIX 6998, FIX 11526). The lent verdict sent with none, because the engine did not know which rows the job's extraction call had read. A step's record keeps those rows since the record kept its call inputs, and an operand names the recorded candidates it is folded from. The step value decoder keeps input_sources and the step record carries it. The operand check joins, per operand, the recorded rows of every step the operand names (OperandBound::sources): none for an operand that names no step, or that names a step whose record keeps none. The lent execution builds each read's set with native's own constructors once the read's labels exist: a correction read under the rows of the candidates that own its questions, a read over a conflict under every member's rows, each with the pack's evidence and the stored rows the labels name. A read that rests on a candidate whose rows are not known sends unsourced, as before and as native does for such a member. Capture only: the run admission records a call's rows and refuses nothing by them. No stored row changes; the record keys are the ones the step already writes. The verdict step's request hash does not move, since the route is no part of the request. One difference from native stays: native asks each candidate before it folds candidates, so a lent operand folded from two steps sends under both steps' rows where native sends under one step's. The set is wider than native's and never narrower. FIX [S69E2B-CANDIDATE-FROM-STEP-RECORD], the last part.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
|
Warning Review limit reached
This review includes 17 billable files and costs up to $4.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 38 minutes for your next included review. View limit details
|
Four tests on the recording route of the verdict fixture, each over a lent generation step that really runs: a correction read over an operand that names its recorded candidate sends one call under the step's own rows, the listed head, the cited TURN and the subject; the same operand without its step sends unsourced; a resolution read over two members sends under both steps' rows and neither unwritten member claim, and unsourced as soon as one member names no step; and over one TURN the lent correction read sends under exactly the rows the native correction read sends under. Before the change the lent verdict names no rows, so the first, third and fourth tests fail there at their first assertion on the bound calls.
The module text said the lent set is never narrower than native's. That holds for what the lent calls read, not against native: a native extraction call reads its whole chunk of TURNs, and a lent step may be given a part of that chunk, so its record, and a read over its candidate, names fewer rows than the native call's. Doc only.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last part of FIX row [S69E2B-CANDIDATE-FROM-STEP-RECORD] (RULING S69E2B-CANDIDATE-OPERANDS = A; parts A and B are #9865 and #9938), with the move-only split of FIX row [LENT-PACK-FILES-NEAR-GIANT-FILE-BAR] as its first commit.
The defect
A native Dreamer decision read sends its model call on a route bound to the rows fixed code read its input from (FIX 6998, FIX 11526;
dreamer_consolidation/request_sources.rs). The call's permit, its receipt and its model-call row then name those rows and their worlds.The lent extraction verdict (
ai.verdictwith an extraction pack) sent every call with no rows (extraction_pack/execution.rs,sources: None), because the engine did not know which rows the job's extraction call had read. Since #9865 a lent step's record keeps those rows (input_sources), and since #9938 an operand names the recorded candidates it is folded from (from_steps). So for such an operand the rows are known, and the lent verdict's calls were the one Dreamer decision read whose receipts named none.The change
Commit 1, move only (FIX [LENT-PACK-FILES-NEAR-GIANT-FILE-BAR]):
llm/step/step_claim.rsandextraction_pack/reads.rswere both 793 lines, seven under the giant-file bar, and this PR adds to the first. The step value decoder moves to the child modulellm/step/step_claim/decode.rs(its two names stay reachable throughstep_claim), and the correction listing (CorrectionListed,correction_sets,restates,cited_claims) to the siblingextraction_pack/correction_listing.rs. Only module lines, imports, two visibility paths (pub(in crate::llm::step)), thepub(super)thatcited_claimsgains with its reflowed signature, and the new module docs differ from the moved text. After the PR:step_claim.rs538,step_claim/decode.rs277,reads.rs689,correction_listing.rs121,execution.rs739.Commit 2, test support only: the extraction verdict fixture lends its role tables a sourced route that sends on the scripted backend and keeps the rows each call was bound to (
test_doors/extraction_verdict/sourced_route.rs;take_bound_source_rows,fixture_step_bound_source_rows).Commit 3, the change (commit 5 corrects one paragraph of its module text, doc only):
llm/step/step_claim/decode.rs,llm/step/request_hash_step.rs: the decoder keepsinput_sources(it checked the key and dropped it) andStepRecordcarries it.extraction_pack/step_records.rs: the operand check returns, per operand, the join of the recorded rows of every step the operand names (OperandBound::sources). It isNonefor an operand that names no step, and for one that names a step whose record keeps no rows.extraction_pack/read_sources.rs(new) andextraction_pack/execution.rs: each read's set is built by native's own two constructors once the read's labels exist, and passed asVerdictRead.sources:correction_source_rows);conflict_source_rows).A read that rests on a candidate whose rows are not known sends unsourced, as before. That is native's own rule for a member whose rows are not known.
Native joins the resolution final's set with each page's. Every page's set is the conflict's one set (the same members and evidence, and labels that name only members and the prior heads, which the evidence lists), so the lent final sends under that set and needs no page sets.
What changes in behaviour
Capture only. The run admission records a call's rows in its permit facts and on its receipts (
llm/run_admission:PermitFacts::source_rows,source_worlds) and refuses nothing by them: no refusal kind ofRunDeniedreads them. A host that lends no sourced route sends as before. No read is refused, held or narrowed by this PR, so no request of the shipped job code can newly fail.This corrects one sentence of my plan note (NOTE PLAN-S69E2B-CANDIDATE-FROM-STEP-RECORD-PR-C, 21 Nov 03:32), which said the admission "judges" a call by its rows' worlds. It records them.
Stored change: none. The record keys are the ones a lent step already writes (#9865). The verdict step's request hash does not move, since the route is no part of the request, so a verdict in flight across the upgrade is served from its memo as before. No verb, no grant and no setting changes.
Where the set differs from native's
The set names every row the lent calls read. That is not always native's set, in two ways:
Over one TURN in one lent step the two sets are equal, and the fourth test asserts it.
Tests
crates/oneiron/tests/extraction_verdict_sources.rs(commit 4), four tests on the recording route, each over a lent generation step that really runs:a_correction_read_over_a_recorded_candidate_sends_under_its_steps_rows: one landed head about the subject, one lent step whose candidate proposes another value. The lent correction read over the operand that names that candidate sends exactly one bound call, and its rows hold every row the step's own call was sent under, the listed head, the cited TURN and the subject.a_correction_read_over_an_operand_that_names_no_step_sends_unsourced: the same operand withoutfrom_stepson a fresh fixture: the verdict answers and no call is bound. A control, green before and after.a_resolution_read_sends_under_every_members_rows: two lent steps over two TURNs, two members of one conflict. The lent resolution read sends one bound call whose rows hold both steps' rows and neither member's unwritten claim id; withfrom_stepsremoved from one member, no call is bound.a_lent_correction_read_sends_under_the_rows_the_native_read_sends_under: on one fixture the native oracle's correction read and the lent correction read bind equal row lists.Run:
RUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test extraction_verdict_sources.Red ref:
opus-split-78/fix-extraction-verdict-source-rows-red(36eff8f = commit 2 of this PR, the door, plus the test file; nothing of the change). Expected there: the first, third and fourth tests fail at their first assertion on the bound calls ("The correction verdict binds its source rows.", "The resolution verdict binds its source rows.", "The lent and native correction reads bind identical source rows."), and the control passes.The fourth test's equality is by reading: it holds if the lent step's recorded rows equal the native slice's rows for a one-TURN attempt (the conversation, the TURN, its MESSAGE, the byline person, the subject, the listed head). If the proof run shows a row of difference, the test's expectation is what is wrong, and a new PR fixes it.
Not compiled, not run
Nothing of this PR has compiled or run. The merge check is its first compile of the engine crate; it builds no test file and no test door, so one compile of the engine crate with the test-door flag and the test files is booked and its result is posted as a note. The tests run on the fleet after the merge (proof part fix-rows-runs21) and the result is posted as a proof note.