Skip to content

READ-LINEAGE L1 on main: a derived row carries its mail sources' floor - #10027

Open
olety wants to merge 1 commit into
mainfrom
opus-unbuilt-b1b/read-lineage-floor-main
Open

olety wants to merge 1 commit into
mainfrom
opus-unbuilt-b1b/read-lineage-floor-main

Conversation

@olety

@olety olety commented Nov 20, 2026

Copy link
Copy Markdown
Member

A row reads to a reader only when every source its words came from reads
to that reader. The row carries the list of those sources (its floor),
written once in the write that gives it its words, so a read meets them
without walking the lineage (Fable design pass 30, section 4; READ-LINEAGE
L1 = L3 = A, the lead 17 Nov 02:0x; E1 = E4 = A). This is #9289's floor cut
onto main alone (Engine TASK 21 Nov 04:31): the sources main holds are
source-audience policies (a mailbox, a shared mail thread). The phone-reach
stack adds a phone thread as a second kind through this same floor.

  • source_audience/floor.rs (new): sealed_source, a reserved id that names
    no source; floor_source_in (E4: by lookup); row_sources_in, one level: the
    walk's lineage, the source dependency index, the birth's inputs of every
    role, a carried summary, and a CLAIM's supports as attestations (one free
    attestation frees, else all bind); raise_floors_in_txn, which only grows
    and repeats until no floor grows; facts_hidden_source_unknown_in.
  • Write hooks: the batch apply (every put and birth, and the end of each
    PartOf, DerivedFrom or Supports edge), the Vault birth doors
    stamp_birth_with_floor_in_txn and _if_absent (13 direct birth sites), a
    replicated birth, and the dependency index and the doors that register
    dependencies with the vault in hand. add_derived_policies_in_txn loses
    its sync gate.
  • A row whose birth names an input this vault erased is born sealed
    (feat(source_audience): a derived row carries its sources' floor (READ-LINEAGE L1) #9289 review r1 P1), as is a row whose lineage does not read.
  • Read: the source-audience walk already honours a stored floor before any
    walk (Judge::open), so a row learnt from a mailbox reads only to that
    mailbox's readers, and a sealed row to no one, the owner included.
  • Admission, the strictest reading until the owner answers the
    OUTSIDER-REACH-FAMILY card (the Engine, 21 Nov 04:30):
    SourceReaders::OwnSourceReaders, the one default SOURCE_READERS that the
    floor read matches on: a policy reads to its own people only.
  • Doctor: VaultDoctorReport.facts_hidden_source_unknown, the count behind
    "N facts hidden: source unknown" (READ-LINEAGE-L3 = A).
  • Ported from Mark phone threads and read them only under the caller's grant (VOICE-PHONE-AGENT-REACH R1) #8609 as they are: store::birth_record::input_rows_in_txn and
    Vault::lineage_word_sources_in.

Stored change: keep (new entries in an existing table today's reader
already honours; a row born before reads as before). No verb.

Tests (RUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test read_lineage_floor)

  • a_claim_born_from_a_mailbox_row_reads_only_to_the_mailboxs_readers: a stranger does not read a CLAIM whose birth alone names a bound mail row; the mailbox's reader does.
  • a_reader_named_by_no_policy_reads_none_of_the_claims_learnt_from_a_mailbox: the measured C3 case (OPUS-LINEAGE-MEASURE, 21 Nov 04:22: under the walk alone a reader named by no policy read all 5,000). 50 CLAIMs born from the mailbox's row by birth input alone: the stranger reads 0, the reader reads 50.
  • a_claim_born_from_an_erased_row_is_sealed (feat(source_audience): a derived row carries its sources' floor (READ-LINEAGE L1) #9289 review r1 P1).
  • a_floor_holds_every_policy_the_walk_meets and doctor_counts_the_facts_a_source_unknown_hides (green only: they need this PR's test door and doctor field).
  • Red: opus-unbuilt-b1b/read-lineage-floor-main-red1 (9479c9e, the first three tests on main a4da017). Green: -pin1 (this head).

Relation to #9289

#9289 is the same floor on the phone-reach stack (base #8667), with the phone thread as a second source kind. Whichever lands first, the other is reworked: after this lands, #9289 keeps only the phone arm (FloorSource::Thread, the phone-thread conjunct, hook 4).

Known limits (as #9289's body lists them, mail only)

  1. Writes that hold only the store are not hooked (the overlay epoch summary, compaction/fold_words.rs, entity_doc promotion and storage, code_run fold_answers, the generic ManifestDbs dependency index): their rows read as today, by the walk.
  2. A landing that writes a row from a row it binds later in the same write gives it nothing from it; the walk still covers the row at read.
  3. A connector conversation (LINE, Slack) is no source yet: READ-LINEAGE L2, after the owner's OUTSIDER-REACH-FAMILY card.
  4. A source put after the words (design limit 5).

… floor

A row reads to a reader only when every source its words came from reads
to that reader. The row carries the list of those sources (its floor),
written once in the write that gives it its words, so a read meets them
without walking the lineage (Fable design pass 30, section 4; READ-LINEAGE
L1 = L3 = A, the lead 17 Nov 02:0x; E1 = E4 = A). This is #9289's floor cut
onto main alone (Engine TASK 21 Nov 04:31): the sources main holds are
source-audience policies (a mailbox, a shared mail thread). The phone-reach
stack adds a phone thread as a second kind through this same floor.

- source_audience/floor.rs (new): sealed_source, a reserved id that names
  no source; floor_source_in (E4: by lookup); row_sources_in, one level: the
  walk's lineage, the source dependency index, the birth's inputs of every
  role, a carried summary, and a CLAIM's supports as attestations (one free
  attestation frees, else all bind); raise_floors_in_txn, which only grows
  and repeats until no floor grows; facts_hidden_source_unknown_in.
- Write hooks: the batch apply (every put and birth, and the end of each
  PartOf, DerivedFrom or Supports edge), the Vault birth doors
  stamp_birth_with_floor_in_txn and _if_absent (13 direct birth sites), a
  replicated birth, and the dependency index and the doors that register
  dependencies with the vault in hand. add_derived_policies_in_txn loses
  its sync gate.
- A row whose birth names an input this vault erased is born sealed
  (#9289 review r1 P1), as is a row whose lineage does not read.
- Read: the source-audience walk already honours a stored floor before any
  walk (Judge::open), so a row learnt from a mailbox reads only to that
  mailbox's readers, and a sealed row to no one, the owner included.
- Admission, the strictest reading until the owner answers the
  OUTSIDER-REACH-FAMILY card (the Engine, 21 Nov 04:30):
  SourceReaders::OwnSourceReaders, the one default SOURCE_READERS that the
  floor read matches on: a policy reads to its own people only.
- Doctor: VaultDoctorReport.facts_hidden_source_unknown, the count behind
  "N facts hidden: source unknown" (READ-LINEAGE-L3 = A).
- Ported from #8609 as they are: store::birth_record::input_rows_in_txn and
  Vault::lineage_word_sources_in.

Stored change: keep (new entries in an existing table today's reader
already honours; a row born before reads as before). No verb.

Tests (read_lineage_floor):
a_claim_born_from_a_mailbox_row_reads_only_to_the_mailboxs_readers,
a_reader_named_by_no_policy_reads_none_of_the_claims_learnt_from_a_mailbox
(the measured C3 case), a_claim_born_from_an_erased_row_is_sealed,
a_floor_holds_every_policy_the_walk_meets,
doctor_counts_the_facts_a_source_unknown_hides.
@greptile-apps

greptile-apps Bot commented Nov 20, 2026

Copy link
Copy Markdown

Automatic reviews are disabled for this repository. Configure in Code Review Settings.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 31 billable files and costs up to $7.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 53 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 151 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 436c6e5 and a6c7d75.

Files selected for processing: 31

  • crates/oneiron/src/actor_claims/imported_chat.rs
  • crates/oneiron/src/actor_claims/write.rs
  • crates/oneiron/src/batch/builder/apply.rs
  • crates/oneiron/src/blob_artifact/versions/append.rs
  • crates/oneiron/src/booking/lifecycle/authorship.rs
  • crates/oneiron/src/code_run/storage/records.rs
  • crates/oneiron/src/dreamer_consolidation/evidence.rs
  • crates/oneiron/src/dreamer_consolidation/open_conflict.rs
  • crates/oneiron/src/dreamer_promotion/writer.rs
  • crates/oneiron/src/ingest/docs_deep.rs
  • crates/oneiron/src/ingest/docs_import.rs
  • crates/oneiron/src/memory/claims/commit/write/landing.rs
  • crates/oneiron/src/memory/coping_doors.rs
  • crates/oneiron/src/note/import.rs
  • crates/oneiron/src/note/verbs.rs
  • crates/oneiron/src/ports/lmdb_aux.rs
  • crates/oneiron/src/provenance/birth.rs
  • crates/oneiron/src/provenance/writes.rs
  • crates/oneiron/src/scope_summary/arc.rs
  • crates/oneiron/src/scope_summary/doors.rs
  • crates/oneiron/src/scope_summary/request/editor_sources.rs
  • crates/oneiron/src/source_audience/floor.rs
  • crates/oneiron/src/source_audience/mod.rs
  • crates/oneiron/src/source_audience/walk.rs
  • crates/oneiron/src/store/birth_record/mod.rs
  • crates/oneiron/src/sync/row_birth.rs
  • crates/oneiron/src/test_doors/house_link.rs
  • crates/oneiron/src/test_doors/mod.rs
  • crates/oneiron/src/test_doors/read_lineage_floor.rs
  • crates/oneiron/src/vault/doctor_manifest.rs
  • crates/oneiron/tests/read_lineage_floor.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant