Repository navigation
Conversation
…tive reads whole A person has a private fact in base reality and a sensitive fact in a second world; the Dreamer's band-1 line stands on the first alone, its band-2 and band-3 lines on both. An identity agent whose one live Grant names base reality, and a paired agent whose own floor is that Grant's envelope, each read the band-1 line whole, yet the roster shows them no line: each alternative asks only for the line at its own band (FIX-LIST PEOPLE-ABOUT-GRANT-LOWER-LINE). A Grant over both worlds shows the top line.
…reads whole about_line_in asked each alternative (the key's own floor, each live Grant alone) for the one line at its band and showed nothing when that alternative did not read the line's every fact, though a lower line, written from the lower bands' facts alone, stood only on rows it reads. ARCH-0067 PEOPLE: "the highest line at or below the reader's ceiling". highest_line_read_whole_in walks down from the alternative's band to the first line it reads whole, in the same snapshot and under the same row judgement as before. A band with no line the Dreamer stands behind (moved or stale facts) ends the walk, as it hid the person's lines before. No Grant lends another a band or a fact; the line shown is still the highest any one alternative shows. FIX-LIST PEOPLE-ABOUT-GRANT-LOWER-LINE.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 56 minutes for your next included review. View limit details
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX-LIST [PEOPLE-ABOUT-GRANT-LOWER-LINE] (P3; found by blind review round 1 of #9929).
The gap
about_line_in(crates/oneiron/src/claim/scoped_read/person_about_lines.rs) asked each roster alternative (the key's own floor, and each live Grant alone) for the oneaboutline at its band, and showed nothing when that alternative did not read the line's every fact. Lines are cumulative: the Dreamer writes the band-b line from the facts at or below b. So a Grant of band 3 whose world axis leaves out a band-2 fact showed no line, though the band-1 line stood only on rows it reads. No leak; a missing line. ARCH-0067 PEOPLE: "The renderer shows the highest line at or below the reader's ceiling."The fix
highest_line_read_whole_inwalks down from the alternative's band: each line the alternative does not read whole gives way to the next lower one, judged in the same snapshot under the same row judgement as before (grant_reads_all_infor a Grant,own_floor_reads_all_infor the own floor). A band with no line the Dreamer stands behind (moved or stale facts,person_about_line_in= None) ends the walk, as it hid the person's lines before; since a lower line's facts are a subset of a higher one's, a stale fact in a lower line is already caught at the top. No Grant lends another a band or a fact (RULING GRANT-COMBINE Q1 = A); the line shown is still the highest any one alternative shows. The own floor takes the same walk (the more elegant version, per the owner's 13 Nov 22:44 line: one rule for every alternative); the owner's own floor reads every row, so his view does not change.Tests (red on main, green on this head; run after merge as the lane's proof part)
New
crates/oneiron/tests/people_about_lower_line.rs(cfgoneiron_test_support): a person with a private fact in base reality and a sensitive fact in a second world; the Dreamer's band-1 line stands on the first alone, its band-2 and band-3 lines on both.a_grant_shows_the_highest_lower_line_it_reads_whole: an identity agent whose one live Grant names base reality sees the band-1 line; with a Grant over both worlds it sees the top line.a_paired_agents_own_floor_shows_the_highest_lower_line_it_reads_whole: the same for a paired agent's credential (own floor = envelope of its Grants).Fleet:
RUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test people_about_lower_lineCommits: fcf1ec7 (tests only, red on main) / 3093ac1 (fix).
Rows change: none. Stored change: none. Verbs: none.