Repository navigation
Conversation
…ng held rows FIX [OWNER-RESERVE-IMPORT-PARTIAL], option B of RULING OWNER-RESERVE-IMPORT = A. Past the owner reserve the owner's verb vault.authority.history.import lands the rows the store door admits and keeps each row the door holds at the reserve, with every row standing on it, in AUTHORITY_HISTORY_RESERVE_HELD (evidence no fold reads). Each write of the observation policy (the floor row) imports the kept rows again, so they land once the floor lets them. Any other refusal refuses the import whole; the other import doors stay whole. No import passes the reserve (C stays out). - log_budget/owner_reserve.rs: the reserve branch of authority_door as held_at_owner_reserve, and held_at_owner_reserve_in_txn for the import. - history_transfer/owner_import.rs: staging in runs in child writers (a refused run rolls back, its prefix restages, the refused row is judged on it; runs restart at one row and double), the held table, the drain after a floor write. - history_transfer.rs: one import body with a staging mode; post-staging checks judge the landed rows only. - Stored change: keep (one new side table, additive).
…-IMPORT-PARTIAL) authority_log_owner_reserve_import: through the owner's verb, the owner's row lands and the flooder's held row waits, landing once the floor is raised with no second import; a row standing on a held row waits with it, a floor write that still holds them keeps them, and both land once the floor lets them. The old whole-door test is renamed for the door it covers.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
|
Warning Review limit reached
This review includes 10 billable files and costs up to $2.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 56 minutes for your next included review. View limit details
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row OWNER-RESERVE-IMPORT-PARTIAL, option B of Engine RULING OWNER-RESERVE-IMPORT = A (15 Nov 17:50; C stays out). Past the owner reserve of [AUTHORITY-LOG-SIGNER-FLOOD], the owner's history import through his verb
vault.authority.history.importrefused whole when it carried one row that is not the owner's work, so his own rows waited until he raised the floor row and imported again. Now his import lands the rows the store door admits and keeps the rest until the floor lets them land.What changes
verbs/authority_history.rs->Vault::import_owner_authority_history, newauthority/history_transfer/owner_import.rs).entry_refsnames the import's rows stored now. The owner's typed check (authority_log_checks,authority_log_owner_reserve) names the reserve while a kept row waits, as before.AuthorityLogFull) rolls back. Its rows before the refused one stage again, and the refused row is judged on them by the reserve's own branch of the door (held_at_owner_reserve_in_txn,log_budget/owner_reserve.rs, split out ofauthority_doorunchanged).judge) read the landed rows only.AUTHORITY_HISTORY_RESERVE_HELD(key hash32, value the row's signed bytes;[restore: live], asAUTHORITY_HISTORY_PENDING). It is evidence that admits nothing: no fold reads it.set_authority_observation_policy, the floor row) the kept rows are imported again as the owner's import. Each lands once the log with it fits under the reserve's start; the rest stay kept.What does not change
import_signed_authority_history(world key bundle import, tests), the sealed-kit restore (_judged, its prelude adopts the image), the authority pages and repair pages.Stored change: keep (one new side table, additive; nothing stored changes meaning). No new verb. The existing owner verb still revalidates the owner first (
owner.revalidate).Tests
RUSTFLAGS="--cfg oneiron_test_support" cargo test --locked -p oneiron --all-features --test authority_log_owner_reserve_import(fixturetests/owner_reserve/two_installs.rs):AuthorityLogFull, nothing written). Through the verb, his row lands,entry_refsnames it alone, and the held row waits with the reserve check named. After the floor is raised, the held row lands with no second import, and the fold is clean.entry_refsempty). A floor write that still holds them keeps them, and the reserve check is named. After the floor is raised, both land.Red pin
opus-anchorsec/owner-reserve-import-partial-red-bc81e7a5(main a4da017 + the tests, no lib change): both tests fail at the verb, which refuses the whole import. The old test inauthority_log_owner_reserve.rsis renameda_whole_history_import_past_the_reserve_refuses_whole_and_lands_once_the_floor_is_raisedand still passes: it covers the whole-history door.