Repository navigation
Carry the typed task assignment conflict on the HTTP facade body and the SDK errors - #10008
Open
olety wants to merge 6 commits into
Conversation
…the SDK errors #9983 refuses a second, different task assignment with a typed MemoryError.task_assignment_conflict (the task, the held assignee and the offered one), and the MCP gateway carries it. The HTTP facade body, the server ApiError and AppError, the OpenAPI error schemas, the remote client, the UniFFI Failure and the TS and Python errors did not, so an HTTP or SDK caller got the 409 and the message but not the typed fields. Each layer now carries the block exactly as check-in P3.8 carried `pending` (058e2cf): the facade body and its OpenAPI mirror (new TaskAssignmentConflictSchema), the replayed-body fields, ApiError (accessor, wire, envelope), AppError, the remote ApiErrorBody, the generator roots (EXTRA_ROOTS, UNIFFI_STREAM_ROOTS, the facade envelope literal), the UniFFI Failure field, OneironError in TS and Python, and the INVALID_STATE remedy in the agent docs. New test tests/task_assignment_conflict_wire.rs: the facade answers 409 with the block. FIX [TASK-ASSIGNMENT-CONFLICT-HTTP-FACADE-FIELD].
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
|
Warning Review limit reached
This review includes 21 billable files and costs up to $5.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 36 minutes for your next included review. View limit details
|
…flict with its typed block
…rror arm The arm answered the 409 with its state and message but no typed block, as ApiError::new leaves it empty (review FIX, REVIEW-10008 error_map.rs:212). It now carries the task and both assignees as the facade's MemoryError does, through a new ApiError::with_task_assignment_conflict builder.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX [TASK-ASSIGNMENT-CONFLICT-HTTP-FACADE-FIELD] (follow-up of #9983; ruling TASK-ASSIGNED-FORK = C: the local approve answers 409 INVALID_STATE with typed fields).
#9983 refuses a second, different task assignment with a typed
MemoryError.task_assignment_conflict(task_ref,held_assignee,offered_assignee), and the MCP gateway carries it. Every other surface dropped it: an HTTP or SDK caller got the 409 and the message, not the fields.This PR carries the block end to end, exactly as check-in P3.8 carried
pending(058e2cf):FacadeErrorBody.task_assignment_conflict(snake_case key, aslegal_hold,room_join_hold,pending), its OpenAPI mirror (newerror/task_assignment_conflict_schema.rs, 32-hex patterns), every fill site infacade/errors.rsincluding the replayed body (REPLAYED_ERROR_FIELDS16 -> 17).ApiError(field, accessor, wire deserialize, envelope),AppError(livequery), the raw error schemas and components.ApiErrorBodyfield, copied into theMemoryErrorit rebuilds.EXTRA_ROOTSandUNIFFI_STREAM_ROOTSrootcrate::memory::TaskAssignmentConflict; the facade envelope literal names it.OneironError::Failure.task_assignment_conflict(lifted record). TS:OneironError.taskAssignmentConflict. Python:OneironError.task_assignment_conflictand stubs. Agent docs: theINVALID_STATEremedy names the block.Test:
crates/oneiron-server/tests/task_assignment_conflict_wire.rs: the facade answers 409INVALID_STATEwith the typed block. Red pin: branchopus-task-proof/proof-assignment-http-field-red(#9983's head b20a975 with the test only): the block is absent.Stored change: none. Wire change: additive (an optional error member). No verb, no grant.
Launch-reset stack only (stack #9823, on #9983).