Repository navigation
Conversation
…lay and names nothing outside the room (FIX ROOM-LOCAL-CUSTODY) The lead's ruling ROOM-LOCAL-CUSTODY = A (21 Nov): handles work only in their room. tests/room_custody_handle_scope.rs: - a_room_handle_meets_its_own_value_when_the_rooms_run_calls_again (red at the layer below: a run bound to the room compares its stored call with base custody's values alone, which hold no room value, so the call made again with the key the room keeps drifts); - a_base_door_refuses_a_room_handle and a_room_handle_names_nothing_of_its_room_in_another_room are guards (a base door refuses `[secret r1]` and `r1` at its parse; another room reads the same handle text as its own). test_doors/erased_request_identity.rs: room_stored_call_is reads the room's call as a run bound to the room reads it, through the session's own matcher (OffRecordSession::base_known_values), not the vault's; room_stored_call_holds reads the stored request's texts. While a room keeps no secret both matchers are one, so the room tests that use it read as before.
…eps, under their room handles (FIX ROOM-LOCAL-CUSTODY) A run bound to an off-record room compares a row it holds with the call it makes again through OffRecordSession::base_known_values, which read base custody's values only. A row the room keeps a fresh key in holds its room handle, which no base value matches, so the call made again drifted: the room handle did not work in its own room. store/known_value_index/room.rs: Vault::known_values_with_room builds the matcher a compare inside the room reads: base custody's values, and beside them each value the room keeps (SessionOverlay::kept_room_secrets), under its room handle and the room's record id, printed under base's master, or a random one while base keys no value. The prints live in that matcher alone and are wiped when it drops: the known-value index learns none. A room handle so meets the value the room keeps under it and no other value, as a base handle meets only its record's values (FIX REPLAY-COMPARE-KNOWN-OTHER-CALLERS). With nothing kept it is known_values_now. OffRecordSession::base_known_values returns it, so every compare of a room's run (the replay cursor, the dispatcher's verb and receipt compares, the erase of a room's replies) reads it. Outside the room no matcher holds a room value, and every base door refuses a room handle at its parse. Stored change: keep.
…layer (FIX ROOM-LOCAL-CUSTODY)
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
|
Warning Review limit reached
This review includes 11 billable files and costs up to $2.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 55 minutes for your next included review. View limit details
|
…cross rooms and through an erase (REVIEW-10003, FIX ROOM-LOCAL-CUSTODY) Three cases the blind review of #10003 found, red on this layer: - a field the side-row wall lifts whole (`password`) holds the bare room handle, and the room's run calling again with the same password does not meet its row (P1 text.rs:257); - two rooms spell their first handles alike, so a handle the first room gave, offered in the second room's call, meets the second room's row (P1 room_secrets.rs:117); - a room's erase of a gone actor's call, in its put fence and its sweep, keeps only the stand-in identity of a room value the request names, so another key of the same shape meets the erased row (P1 overlay_erase.rs:208). test_doors/erased_request_identity.rs: store_fields_call_in_room and room_stored_fields_call_is, a note call held as a map of texts.
…ld and through an erase (REVIEW-10003, FIX ROOM-LOCAL-CUSTODY) oneiron-store session_overlay/overlay/room_secrets.rs: a room handle is the sigil, the room's tag and the handle's ordinal there (`r0123456789abcdef.1`). The tag is 64 random bits drawn at the room's first kept secret, so two rooms never spell a handle alike: a handle one room gave meets nothing another room keeps, in a row or in a call (the replay compare's `stored == offered` hit). The dot keeps it outside the durable short-id grammar, as before. batch/secret_scan: a whole value that is a bare room handle is a handle, as a bare `sc12` is: the replay compare reads it as a slot (text.rs handle_spans), the erased form stands it in (side_row.rs stand_in_text) and the shape rules read it as no secret (shapes.rs custody_handle). A field the wall lifts whole in a room holds the bare room handle, and the room's run calling again with the same value now meets its row. code_run/storage: an erase inside a room reads the room's values beside base custody's (replay_bodies.rs WriterCustody::in_room, backed by known_value_index/room.rs KnownValues::with_room_in_writer, which shares its matcher with Vault::known_values_with_room): the room's put fence and its sweep (overlay_erase.rs) keep the exact identity of a room value a request names, as they keep a base value's. Stored change: keep (room handles live only in a room's memory; base holds none).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX ROOM-LOCAL-CUSTODY, PR 2 of 3 (stack: kept -> this PR -> save). Ruling: see PR 1.
This PR: a room handle works only in its room.
A run bound to an off-record room compares a row it holds with the call it makes again through
OffRecordSession::base_known_values, which read base custody's values only. A row the room keeps a fresh key in holds its room handle, which no base value matches, so the call made again drifted: the handle did not work in its own room.store/known_value_index/room.rs(new):Vault::known_values_with_roombuilds the matcher a compare inside the room reads: base custody's values and, beside them, each value the room keeps under its room handle and room record id, printed under base's master (or a random one while base keys no value). The prints live in that matcher alone and are wiped when it drops; the known-value index learns none. A room handle so meets its own value and no other value of its shape, as a base handle meets only its record's values (FIX REPLAY-COMPARE-KNOWN-OTHER-CALLERS).OffRecordSession::base_known_valuesreturns it, so every compare of a room's run reads it (replay cursor, dispatcher verb/receipt compares, the erase of a room's replies). Outside the room no matcher holds a room value, and every base door refuses a room handle at its parse (PR 1).Stored change: keep.
Tests (
... --test room_custody_handle_scope; red commit 65d021b on PR 1's tip, pinopus-fix-custody/room-local-custody-handle-scope-red):a_room_handle_meets_its_own_value_when_the_rooms_run_calls_again(red at PR 1: drifts);a_base_door_refuses_a_room_handle,a_room_handle_names_nothing_of_its_room_in_another_room.test_doors/erased_request_identity.rsroom_stored_call_isnow reads the room's call through the session's matcher, as the room's run does (identical while a room keeps nothing, soerased_request_custody_identityandfenced_erase_stand_in_identityread as before).Review round 1 (REVIEW-10003)
r<room tag>.<ordinal>(r0123456789abcdef.1), the tag 64 random bits per room, so two rooms never spell a handle alike.WriterCustody::in_room,KnownValues::with_room_in_writer), so an erased request keeps the exact identity of a room value it names.Tests: three more in
tests/room_custody_handle_scope.rs, red at 26ee474.