fix(token): day_string epoch fallback + rollup scan returns error not panic#261
Merged
Conversation
… panic Post-merge Copilot round-3 findings on v3.4.12: - token_gain::day_string still fell back to Utc::now() for an out-of-range ts — the exact behavior the new rollup utc_or_epoch avoids. Match it (Unix EPOCH) so both agree; a corrupt ts buckets under 1970, not today. - rollup::scan used .expect() on a malformed key → process crash on an externally corrupted redb. Return a new RollupError::MalformedKey instead (the fn already returns Result). Add a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot round-3 findings on v3.4.12 (tag still held):
Utc::now()fallback for an out-of-range ts, the exact behavior the newrollup::utc_or_epochavoids. Now falls back to the Unix EPOCH so both agree (corrupt ts → 1970, self-flagging, not today)..expect()on a malformed key would crash the process on an externally-corrupted redb. Returns a newRollupError::MalformedKeyinstead (the fn already returnsResult). + test.fmt + clippy clean; rollup + token_gain tests pass.