fix(token): epoch fallback for out-of-range rollup ts + drop informal comment#260
Merged
Conversation
…comment Post-merge Copilot findings on v3.4.12: - rollup day/month/year_key fell back to Utc::now() for an out-of-range timestamp, which would bucket a corrupt event under TODAY and pollute the current period's rollup. Fall back to the Unix EPOCH instead (obviously wrong, self-flagging) via a shared utc_or_epoch helper. Add a test. - Drop the informal '(Copilot)' attribution from the fake-daemon read-loop comments in token_check.rs / token_gain.rs test code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge Copilot autoreview findings on the v3.4.12 changes (tag held until these land):
day_key/month_key/year_keyfell back toUtc::now()for an out-of-range timestamp, bucketing a corrupt event under today and polluting the current period's rollup. Now falls back to the Unix epoch (self-flagging under 1970) via a sharedutc_or_epochhelper + test.(Copilot)attribution from the fake-daemon read-loop test comments.fmt + clippy clean; rollup + token tests pass.