Skip to content

ci: optimize Prospector static analysis workflow#3103

Open
ukanga wants to merge 1 commit into
mainfrom
optimize-prospector-ci
Open

ci: optimize Prospector static analysis workflow#3103
ukanga wants to merge 1 commit into
mainfrom
optimize-prospector-ci

Conversation

@ukanga
Copy link
Copy Markdown
Member

@ukanga ukanga commented Jun 3, 2026

Changes / Features implemented

  • Optimized the Prospector static analysis workflow.
  • Added APT package caching for the Prospector job.
  • Moved the Prospector job APT package list into .github/apt-packages.txt so the cache key can be based on the package list.
  • Removed the redundant Install linting tools step because prospector==1.18.0 and pylint==4.0.5 are already installed from requirements/dev.pip.

Steps taken to verify this change does what is intended

  • Confirmed .github/workflows/ci.yml parses as valid YAML.
  • Confirmed the updated APT install shell block passes shell syntax validation.
  • Confirmed requirements/dev.pip includes:
    • prospector==1.18.0
    • pylint==4.0.5
  • Ran Prospector locally:
DJANGOSETTINGSMODULE=onadata.settings.githubactionstest \
  .venv/bin/prospector -X -s veryhigh onadata


Result: Messages Found: 0

Side effects of implementing this change

  • The Prospector CI job should spend less time downloading APT packages on cache hits.
  • No expected change to the Prospector analysis behavior or command.

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #3064


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@ukanga ukanga force-pushed the optimize-prospector-ci branch from 4d7a33d to 68c6091 Compare June 3, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: optimize Prospector static analysis workflow

1 participant