Conversation
|
This PR has been staged at https://3e006ade.omsf.pages.dev. It has been updated for commit 782f096. |
dwhswenson
left a comment
dwhswenson
left a comment
There was a problem hiding this comment.
A few small things I would change; and definitely check on the name of the directory.
Any reason not to just use the install.py script we have in static-site-tools? At worst, put them in some other directory and copy the ones you still need into .github/workflows.
.github/workflows/build-push.yml
Outdated
| - name: Install Node.js dependencies | ||
| run: "[[ -f package-lock.json || -f npm-shrinkwrap.json ]] && npm ci || true" |
There was a problem hiding this comment.
Do we have any node dependencies here?
.github/workflows/build-push.yml
Outdated
| run: tar czf site.tar.gz public | ||
|
|
||
| - name: Upload build artifact | ||
| if: ${{ github.event_name != 'schedule' }} |
There was a problem hiding this comment.
you don't have scheduled builds in this; don't need this line
| if: ${{ github.event_name != 'schedule' }} |
| with: | ||
| run-id: ${{ github.event.workflow_run.id }} | ||
| project-name: ${{ vars.CLOUDFLARE_PROJECT_NAME }} | ||
| html-dir: _site |
There was a problem hiding this comment.
tbh, not sure if this should be _site or public; I think Hugo uses public, and IIRC, _site is from Jekyll. In the example, it looks like it is public (I don't think that var is defined).
I honestly forgot we added this. |
2 participants
Adds support for full migration to Cloudflare pages when we want to go there.