PTD-23.1.1: Canonicalize Python support claims

[omry]

Add provider-owned minor-series and exact-patch claim normalization and intersection. Enforce canonical claims in binding records and solver accumulation, including cumulative active-provider intersection coverage.

---

• -> PTD-23.1.1: Canonicalize Python support claims #145
• Split PTD-23.1 into review-sized delivery items #143
• Tighten portable Python binding delivery plan #142

[omry]

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)

{
  "approval": {
    "candidate_revision_fingerprint": "sha256:dcdc24b3a844e2ad5454ba2a6802c95611262ca49ee2529aea6b0db71b8f4ae1",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:dcdc24b3a844e2ad5454ba2a6802c95611262ca49ee2529aea6b0db71b8f4ae1",
      "check_conclusions": [],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:92ac167dad3633afbf6d047a98e575702b1163e106df3f82e2450c6d4b619d04",
      "review_request": {
        "body_digest": "sha256:abdf3556d3d2f817d1cbadf54c13dd0f3a5fe25edd5e8232a93033511a2e6ac1",
        "id": 5648750621
      },
      "review_result": {
        "body_digest": "sha256:773cab84eaabd37476fcd900e2aa40ca84779559d9a542d49930495fba20a784",
        "id": 5648761808
      }
    },
    "evidence_fingerprint": "sha256:36cc183d264f66b7fbbea30ff008be8f27153fa724b4e16b5b45252b5e759084",
    "head_sha": "64a0caf7a4ce572b5ef211f0dc02bb03eb8c2fa9",
    "operation_identity": "sha256:92ac167dad3633afbf6d047a98e575702b1163e106df3f82e2450c6d4b619d04",
    "review_request_id": 5648750621,
    "review_result_id": 5648761808,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:dcdc24b3a844e2ad5454ba2a6802c95611262ca49ee2529aea6b0db71b8f4ae1",
  "check_conclusions": [],
  "check_observations": [
    {
      "checks": [],
      "head_sha": "64a0caf7a4ce572b5ef211f0dc02bb03eb8c2fa9",
      "id": "sha256:014189fd8b5d02583f6f087d875b9f26aba17b7fdd60575016dccee2e7e1ceba",
      "required_checks": [],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "pr143",
    "base_sha": "4f0e4249d48ae4f3d8c4d135180fba096a26262f",
    "body_digest": "sha256:ed86b08fdf6f8a34d9c59a9571b77925862bc7d5027b5f20198bafd0884d440a",
    "diff_digest": "sha256:18f4c03dfefaeab84e7f7ac5c76d6b3341689552e0421b7371dfd4d78377ccdf",
    "head_ref": "pr144",
    "head_sha": "64a0caf7a4ce572b5ef211f0dc02bb03eb8c2fa9",
    "pr": 145,
    "repository": "omry/reploy",
    "scope_authority": [
      {
        "digest": "sha256:bd02f5450b2940b3a960f6419994aa9c4e5e65ccb4dc5365b4d17ac233b49d9d",
        "path": "docs/PORTABLE_TOOL_DEFINITION_DESIGN.md"
      },
      {
        "digest": "sha256:570286ac642fd82e3177fb8ddb36dd15ee97395470726d69df086508be174a2e",
        "path": "docs/PORTABLE_TOOL_DEFINITION_IMPLEMENTATION_PLAN.md"
      }
    ],
    "title_digest": "sha256:672b70a810833ced9e7b88f748c11bf7c4e5ec92aed313df8f598972ac6a8f65"
  },
  "record_version": 5,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-09-12T11:08:29Z",
      "base_ref": "pr143",
      "base_sha": "4f0e4249d48ae4f3d8c4d135180fba096a26262f",
      "body_digest": "sha256:abdf3556d3d2f817d1cbadf54c13dd0f3a5fe25edd5e8232a93033511a2e6ac1",
      "created_at": "2026-09-12T21:17:51Z",
      "head_sha": "64a0caf7a4ce572b5ef211f0dc02bb03eb8c2fa9",
      "id": 5648750621,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "pr143",
      "base_sha": "4f0e4249d48ae4f3d8c4d135180fba096a26262f",
      "body_digest": "sha256:773cab84eaabd37476fcd900e2aa40ca84779559d9a542d49930495fba20a784",
      "commit_id": "64a0caf7a4ce572b5ef211f0dc02bb03eb8c2fa9",
      "id": 5648761808,
      "inline_message_ids": [],
      "request_comment_id": 5648750621,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-09-12T21:20:01Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOTFQCkM6hvmIe",
        "PRRT_kwDOTFQCkM6hvrKt"
      ]
    }
  ],
  "revision_fingerprint": "sha256:dcdc24b3a844e2ad5454ba2a6802c95611262ca49ee2529aea6b0db71b8f4ae1",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:18f4c03dfefaeab84e7f7ac5c76d6b3341689552e0421b7371dfd4d78377ccdf",
      "finding_ids": [],
      "invariants": [
        "Provider-canonical Python support claims remain a fixed point accepted by binding-record validation.",
        "Shared Python-domain support is intersected semantically in solver accumulation and provider DAG validation.",
        "The exact reviewed head passes the complete repository validation profile."
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "64a0caf7a4ce572b5ef211f0dc02bb03eb8c2fa9",
      "review_observation_id": null,
      "review_request_id": 5648750621,
      "review_result_id": 5648761808,
      "reviewed_head": "64a0caf7a4ce572b5ef211f0dc02bb03eb8c2fa9",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-12T21:20:02.035429Z	64a0caf	Manual request
🔒 Security Review	✅ Completed 2026-09-12T11:26:40.265469Z	bfb27d0	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bfb27d07db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[gitar-bot]

Code Review 👍 Approved with suggestions 1 resolved / 2 findings

Adds provider-owned minor-series and exact-patch claim normalization and intersection with canonical claim enforcement in binding records and solver accumulation. Consider adding a shared test corpus to guard against drift between the duplicate canonical-claim logic in record_validate.go and providers — if either implementation changes without the other, published records could validate at record time yet be rejected during solving, breaking the stated invariant.

💡 Quality: Duplicate canonical-claim logic risks drifting out of sync

📄 internal/portabletool/record_validate.go:210-224 📄 internal/providers/python_claim.go:79-93

validatePortableToolSupportedPythonClaimsV1 in record_validate.go hand-rolls the canonical-claim rules (sorted, unique, no exact patch subsumed by a same-minor series), while providers.NormalizeSupportedPythonClaimsV1/IntersectSupportedPythonClaimsV1 implement the same contract independently for the solver. The solver assumes binding records that passed record validation are already fixed points of the provider normalizer; if either implementation changes (e.g. a new subsumption rule) without the other, published records can validate at record time yet be re-reduced or rejected during solving, breaking the stated invariant that a record rejected at publication cannot become acceptable after locking. Since portabletool cannot import providers (import cycle), consider a shared test asserting the two implementations agree on a corpus of claim lists to guard against drift.

✅ 1 resolved

✅ Quality: Missing Changie fragment for claim-canonicalization change

📄 internal/portabletool/record_validate.go:210-224 📄 internal/toolcatalog/solver.go:339-348
This PR enforces canonical Python support claims in binding records and active-provider constraints, so records that previously validated (e.g. unsorted or non-normalized supported_python lists) will now be rejected — a maintainer-facing behavior change. Per the changelog convention, add a .changes/unreleased/ fragment (e.g. kind Changed) describing the new normalization/enforcement.

🤖 Prompt for agents

Code Review: Adds provider-owned minor-series and exact-patch claim normalization and intersection with canonical claim enforcement in binding records and solver accumulation. Consider adding a shared test corpus to guard against drift between the duplicate canonical-claim logic in `record_validate.go` and `providers` — if either implementation changes without the other, published records could validate at record time yet be rejected during solving, breaking the stated invariant.

1. 💡 Quality: Duplicate canonical-claim logic risks drifting out of sync
   Files: internal/portabletool/record_validate.go:210-224, internal/providers/python_claim.go:79-93

   `validatePortableToolSupportedPythonClaimsV1` in record_validate.go hand-rolls the canonical-claim rules (sorted, unique, no exact patch subsumed by a same-minor series), while `providers.NormalizeSupportedPythonClaimsV1`/`IntersectSupportedPythonClaimsV1` implement the same contract independently for the solver. The solver assumes binding records that passed record validation are already fixed points of the provider normalizer; if either implementation changes (e.g. a new subsumption rule) without the other, published records can validate at record time yet be re-reduced or rejected during solving, breaking the stated invariant that a record rejected at publication cannot become acceptable after locking. Since `portabletool` cannot import `providers` (import cycle), consider a shared test asserting the two implementations agree on a corpus of claim lists to guard against drift.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

[omry]

@codex, regular review 64a0caf

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 64a0caf7a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".