Skip to content

Release v1.43.1: skills integrity and Events validation - #214

Merged
omriariav merged 3 commits into
mainfrom
codex/v1-43-1-skill-audit
Aug 4, 2026
Merged

Release v1.43.1: skills integrity and Events validation#214
omriariav merged 3 commits into
mainfrom
codex/v1-43-1-skill-audit

Conversation

@omriariav

Copy link
Copy Markdown
Owner

Summary

  • align all source skill versions with the 1.43.1 package version and enforce source/mirror parity
  • add canonical RELEASE.md with mandatory skills and automated-review-content gates
  • clarify Chat and Drive routing to Workspace Events subscriptions
  • reject non-positive events subscriptions list --max values before client creation

Validation

  • go test -count=1 ./...
  • go vet ./...
  • make build
  • make release-check

Related: #213

…ASE.md

- Every source skills/*/SKILL.md version set to the release version
  1.43.1; new TestSkillVersions_MatchPackageVersion enforces source
  skill versions == Claude plugin manifest version for future releases
- Codex mirrors stay version-free by design and byte-identical after
  version stripping (existing mirror contract unchanged)
- Makefile VERSION, both plugin manifests, CLAUDE.md to 1.43.1
- gws-chat skill: cross-references gws-events for push subscriptions,
  clarifies service-account-app covers only individual Chat-space event
  subscriptions (send/notify force/silent remain rejected), and points
  DWD setup at auth_mode service-account-dwd
- gws-drive skill: new Change Notifications section routing push
  notifications to gws-events (polling stays with changes/activity)
- Audited remaining skills: no other material inaccuracies, no churn
- New canonical RELEASE.md: hard release gates incl. mandatory skill
  gates (uniform source versions, version-free content-synced Codex
  mirrors, per-release skill capability/scope/exclusion audit,
  release-check enforcement, no publish before bundle check);
  CLAUDE.md Release Checklist now points to RELEASE.md keeping only
  the non-negotiable safety rules; Makefile release-check help text
  states it includes skill integrity checks

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Summary

This patch bumps v1.43.1, standardizes skill versions, adds release safeguards, clarifies Chat/Drive event documentation, and validates non-positive events subscriptions list --max values.

What looks good

  • --max returns the project’s standard usageError.
  • Validation occurs before authentication or API work.
  • Zero and negative values have regression coverage.
  • Skill mirrors and manifests remain synchronized.
  • Release documentation and notes are updated.
  • git diff --check passes.

Issues found

Warning

  • cmd/events_test.go:526: The “valid max” test calls runEventsSubsList without isolating credentials or mocking HTTP. It assumes authentication will fail, but on a configured developer or CI machine it could contact the real Workspace Events API, making the test environment-dependent and potentially exposing subscription metadata. Remove this subtest or inject isolated configuration and an httptest server.

I could not execute go test ./cmd because the read-only environment prevented Go from creating its module cache. The PR should address the test isolation issue before merge.

The valid-max subtest called runEventsSubsList without isolated
config/HTTP, so it could reach a real API when credentials exist. The
zero/negative usage-error cases remain: they prove --max validation
happens before any auth or API work.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Summary

This patch adds --max validation for Events subscription listing, aligns skill/plugin versions to v1.43.1, and introduces a canonical release procedure.

What looks good

  • --max <= 0 returns the project’s standard usageError.
  • Regression tests cover zero and negative values.
  • Source and mirrored skill changes remain synchronized.
  • Release documentation is substantially clearer.

Issues found

Critical

  • cmd/skills_test.go:1085 — The version gate ignores an overridden release version. make release VERSION=1.43.2 runs tests that read the literal VERSION ?= 1.43.1 from the Makefile, so they pass while the release target tags and builds v1.43.2 with v1.43.1 manifests and skills. The test must validate the effective release version, or the release target must reject overrides that differ from the checked-in version.

Warning

  • RELEASE.md:43 says every listed skill gate is enforced by tests, but the manual “skill content audit” in item 3 cannot be test-enforced. Clarify which requirements are automated versus procedural.

Testing could not run because the read-only environment prevented Go from creating its module cache. The PR is not ready to merge until the release-version mismatch is fixed.

…kill audit

- New version-preflight target runs FIRST in release-check (and thus
  release): a VERSION override differing from the checked-in Makefile
  VERSION fails with a clear error before fmt/vet/test, so an override
  can no longer bypass the source-skill/manifest version tests. Omitting
  VERSION or passing the matching value passes.
- RELEASE.md now distinguishes the test-enforced skill gates (versions,
  mirrors, inventory — items 1/2/5) from the mandatory manual content
  audit (item 3), which must be evidenced in the release PR review and
  is not claimed test-enforced; make release docs state X.Y.Z must equal
  the checked-in version. CLAUDE.md summary and RELEASES.md updated.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Summary

This PR releases v1.43.1, adds release/version integrity gates, improves Chat/Drive skill guidance, and rejects non-positive events subscriptions list --max values.

What looks good

  • Validation returns the project’s standard usageError.
  • Regression tests cover zero and negative values.
  • Skill mirrors and manifest versions remain consistent.
  • Release documentation clearly distinguishes automated and manual gates.
  • git diff --check passes.
  • Version preflight succeeds normally and rejects mismatched overrides.

Issues found

No Critical, Warning, or Suggestion issues found. The PR is clean and ready to merge.

Full go test ./... execution was prevented by the read-only environment’s inability to create a Go module cache; CI should provide final test confirmation.

@omriariav
omriariav merged commit 793396c into main Aug 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant