Move new chat advanced settings into agent picker#720
Open
ahirreddy wants to merge 2 commits into
Open
Conversation
…de-in sub-page The new-chat composer showed "Advanced settings" as a separate fourth config chip whenever Claude Code / Codex / Polly / Debby were selected, which was awkward. Roll it into the agent picker dropdown instead. - Make the agent picker a controlled dropdown with two horizontally sliding pages within the one popover surface (so it works on mobile, no off-screen flyout): the agent list and the selected agent's Advanced settings. - Picking an agent that has Advanced settings keeps the menu open and surfaces an "Advanced settings" row that slides to page 2; agents without knobs close on pick as before. - The sliding viewport's height tracks the visible page (measured via useLayoutEffect + ResizeObserver, guarded for jsdom) so the popover resizes with the slide. The off-screen page is inert + aria-hidden. - Remove the standalone Advanced settings footer chip. Tests drive the new flow (open picker -> Advanced settings -> pick); the advanced-chip testid is replaced by advanced-entry/advanced-back. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Note: npm ci currently fails on upstream main because ap-web/package-lock.json is out of sync with package.json for yaml (lock has 1.10.3, package resolution wants 2.9.0), so local verification used npm install --package-lock=false.