feat(onboarding): full-screen first-run welcome wizard - #268
Merged
Merged
Conversation
First launch showed only a small inline hint banner (plus, on macOS, the accessibility prompt), leaving Windows users with no guidance at all. Add a modern 3-step full-screen welcome: what QlipLab does → your summon shortcut (shown as a live kbd) → offer launch-on-login, then Get started. - WelcomeWizard.tsx: cross-platform, RTL-aware, i18n; pure welcomeFinishPatch / clampStep helpers extracted for testing - settingsStore: welcomeSeen (distinct from onboardingSeen so each retires independently; the wizard also retires the inline banner on finish) - App.tsx: gate the error-reporting opt-in behind welcomeSeen so the two full-screen surfaces never stack - i18n: 14 welcome.* keys across all 15 locales - 10 tests (pure logic + i18n render/interaction) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
First launch showed only a small inline hint banner (plus, on macOS, the accessibility prompt) — Windows users got no guidance at all. This adds a modern, cross-platform first-run experience.
What
A 3-step full-screen welcome wizard:
kbd, plus Enter-to-paste / arrow-key hintsDetails:
WelcomeWizard.tsx— cross-platform, RTL-aware, fully i18n'd. PurewelcomeFinishPatch/clampStephelpers extracted so the persisted outcome and step math are unit-tested.settingsStore: newwelcomeSeen(distinct fromonboardingSeen, so each surface retires independently; finishing the wizard also retires the old inline banner).App.tsx: the error-reporting opt-in is now gated behindwelcomeSeen, so the two full-screen surfaces never stack on first run.welcome.*keys added to all 15 locales.Tests
10 new tests (pure logic + i18n render/interaction). Full suite green: 618 passing,
tscclean.🤖 Generated with Claude Code