fix: no stray focus ring on launch / search click - #262
Merged
Conversation
The earlier focus-visible change didn't cover the real cause. On every window re-open the OS restores focus to the last-clicked sidebar button, which the browser treats as focus-visible — painting a full orange ring around the History icon on launch. The search field also glowed on click via a focus-within ring. - Sidebar buttons: drop the focus-visible ring. The active tab's accent fill already signals the current view, and restored focus can no longer leave a ring on open. - Search field: remove the focus-within ring for a static, Spotlight-clean box (the caret is the focus cue). - Focus the search input on every window open, so typing filters immediately and focus never sits on a sidebar button to begin with. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier focus-visible change (#239) didn't cover the real cause.
Root cause
On every window re-open, the OS restores focus to the last-clicked sidebar button, which the browser treats as
:focus-visible— so a full orange ring painted around the History icon on launch. The search field also glowed on click via afocus-withinring.Fix
focus-visiblering. The active tab's accent fill already shows the current view, and restored focus can no longer leave a ring on open.focus-withinring for a static, Spotlight-clean box (the caret is the focus cue).tscclean · 608 tests green · verified live via HMR.🤖 Generated with Claude Code