rtl: logical inset for transform picker + pause dot - #259
Merged
Merged
Conversation
Two spots still used physical left/right instead of logical inset, so they sat on the wrong side under an RTL language: - PreviewPanel transform picker popover: `left-0` → `start-0`, so the 520px panel opens from the reading-start edge instead of always the physical left. - Sidebar capture-paused status dot: `right-1` → `end-1`. (The window resize handles keep physical left/right — those track real window edges, not reading direction.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two spots still used physical
left/rightinstead of logical inset, so they landed on the wrong side under an RTL language:left-0→start-0(the 520px panel opens from the reading-start edge, not always the physical left).right-1→end-1.Window resize handles intentionally keep physical left/right — they track real window edges, not reading direction.
tscclean · 608 tests green.🤖 Generated with Claude Code