a11y: keyboard access to history row actions - #256
Merged
Conversation
The history list uses a roving aria-activedescendant model, so focus never leaves the container and the per-row action buttons (which appear on hover) were unreachable by keyboard. Two changes close that gap: - Row actions now also reveal on the keyboard-selected row, so a keyboard user can see what's available (pin state, edit, menu) — not just mouse hoverers. - Cmd/Ctrl+E edits/opens the selected clip, checked before the input guard (like Cmd/Ctrl+Backspace delete) so it works while the search box keeps focus. Paste (Enter), plain paste (Shift+Enter) and delete (Cmd/Ctrl+Backspace) were already keyboard-driven; edit completes the set. Tests: Ctrl+E edits the highlighted row; a bare "e" does not (search-safe). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The history list uses a roving
aria-activedescendantmodel — focus never leaves the container, so the per-row action buttons (hover-only) were unreachable by keyboard.Changes
Tests
Ctrl+E edits the highlighted row; a bare "e" does not (search-safe).
tscclean · 608 tests green.🤖 Generated with Claude Code