feat: cross-tab search hints (unified search) - #254
Merged
Conversation
Searching in one tab now surfaces how many matches exist in the others, so "where did I save that?" is one click away. A thin bar under the filter row shows a chip per other tab with a match count; clicking it switches tab and carries the query across (goToTabWithSearch keeps the search instead of clearing it like normal tab switches). - database.countSnippetMatches(query) — SQL count mirroring the snippet search (title/content LIKE ESCAPE), 0 for blank without a DB hit. - History/Snippet counts via SQL; Vault counts in memory, title-only, and only while unlocked (contents are encrypted) — so a locked vault never leaks a count. - appStore.goToTabWithSearch preserves the query; the sidebar's normal setActiveTab still clears it. - CrossTabSearchHints rendered on all three list tabs. Tests: countSnippetMatches blank-query short-circuit. i18n: search.alsoIn ×15. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth and final "wow" feature: searching in one tab surfaces how many matches exist in the others, so "where did I save that?" is one click away.
A thin bar under the filter row shows a chip per other tab with a match count; clicking it switches tab and carries the query across (
goToTabWithSearchkeeps the search rather than clearing it like a normal tab switch).How
database.countSnippetMatches(query)— SQL count mirroring the snippet search (title/content LIKE ESCAPE); 0 for a blank query without a DB hit.appStore.goToTabWithSearchpreserves the query; the sidebar's normalsetActiveTabstill clears it.CrossTabSearchHintsrendered on all three list tabs.Tests
countSnippetMatchesblank-query short-circuit. i18n:search.alsoIn×15.tscclean · 606 tests green.🤖 Generated with Claude Code