ux: teach the summon shortcut in onboarding - #247
Merged
Conversation
The onboarding banner covered copy/paste/navigate/diff but omitted the one thing that makes the app usable — the global shortcut that opens QlipLab from anywhere. New users had no way to discover it short of opening Settings. Added a prominent hint showing the actual configured shortcut in a <kbd>, formatted per platform. Extracted the accelerator formatter out of SettingsDialog into `lib/formatShortcut` (pure, unit-tested) so the banner and settings render "Cmd + Shift + V" / "Ctrl + Shift + V" identically and never drift. Tests: 6 for formatShortcut (Cmd/Ctrl, Option/Alt, backquote, empty). i18n: onboarding.hint.summon across 15 locales. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onboarding banner taught copy / paste / navigate / diff but omitted the one thing that makes the app usable — the global shortcut that opens QlipLab from anywhere. New users could only discover it by opening Settings.
Change
<kbd>, formatted per platform.SettingsDialogintolib/formatShortcut(pure, unit-tested), so the banner and Settings renderCmd + Shift + V/Ctrl + Shift + Videntically and can't drift.Tests
6 for
formatShortcut(Cmd/Ctrl, Option/Alt, backquote symbol, empty). i18n:onboarding.hint.summonacross all 15 locales.tscclean · 563 tests green.🤖 Generated with Claude Code