-
Notifications
You must be signed in to change notification settings - Fork 105
Api wells #5047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Api wells #5047
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
7c632bb
Add /wells/ ordered by column, row NOT name
will-moore 1843443
Blitz buildQuery() remove lower(obj.%s) from order_by
will-moore f26b10e
ObjectsView order_by uses 'obj.'
will-moore 02bd39b
Blitz Well.getQueryString() supports filter by 'plate'
will-moore e630df5
Filter Wells by ?plate=id or /plates/id/wells
will-moore 51bc36c
Add wells_url to /plates/:id/ json
will-moore 7b785cc
Blitz Well.getQueryString() supports 'load_images'
will-moore 9139d69
Blitz Well.getQueryString() supports load_pixels & load_channels
will-moore 6fec387
add_data(urls={}) can be used with specified urls
will-moore bf22ebb
Add WellView with add_data() to add urls to Images
will-moore 43f5971
flake8 fixes
will-moore b4fe99f
Use 'url:wells' for wells in Plate json
will-moore f2d4fbf
Load images for /wells/ and pixels for /wells/:id
will-moore af784b9
Also add 'url:image' to Images in /wells/
will-moore 9b8d9a0
New test_api_wells.py tests lising /wells/ and /wells/:id/
will-moore d645be8
Blitz Well getQueryString() also loads plateAcquisition with wellSample
will-moore ff4a187
flake8 fixes
will-moore 7a5ca34
Blitz Well _getQueryString uses 'left outer join' for plateAcquisition
will-moore d474461
Added 'url:well' test to test_api_containers.py
will-moore 88637ca
Merge remote-tracking branch 'origin/develop' into api_wells
will-moore 3bc0096
flake8 fixes
will-moore ff3711b
Blitz fixes for PR #5047
will-moore e02844b
test_api fixes for PR #5047
will-moore 84ad329
Add PlateAcquisition to test_api_wells.py
will-moore 7664049
flake* and pep8 fixes for test_api_errors.py
will-moore 2314276
Blitz flake8 fixes
will-moore 256ce26
flake8 fix
will-moore 1c0dbc6
test_plate_wells() tests plates with & without plate_acquisition
will-moore 8797960
Blitz getPixelsQuery() helper
will-moore 3a90c5c
Typos in web api tests
will-moore 78a5a94
Blitz flake8 fix
will-moore 852c3ed
Temp use chris' well-wellsample-image branch of omero-marshal
will-moore 024a188
Don't use urls={} in ApiView.add_data()
will-moore 8eb3ad2
Revert "Temp use chris' well-wellsample-image branch of omero-marshal"
will-moore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if that is placeholder why
OBJECT_IDnot just None ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OBJECT_IDis a unique identifier that this should be replaced with the ID of the current object. It's possible that other IDs could be used in future. UsingNonedoesn't explicitly say what the placeholder should be replaced with.