feat: add field to initial setup to set the vm disk size - #141
Draft
semeano wants to merge 1 commit into
Draft
Conversation
themartiano
requested changes
Sep 8, 2026
themartiano
left a comment
themartiano
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the pull request!
Codex comments
Please bound the decimal input before shell arithmetic. OMARCHY_QEMU_GPU_DISK_SIZE_GB=18446744073709551640 currently wraps to 24 and passes the 8192 limit; add an overflow regression test. Rebase onto #135, and document the Rust/ttfx pin and binary-checksum validation included in this disk-size PR. Keep it draft until the new/reset VM path is validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #104 and #132 for new/reset VM capacity; existing-disk growth is tracked in #154.