Hide relocated debug commands from the Omarchy router - #10328
Closed
surim0n wants to merge 1 commit into
Closed
Conversation
The omarchy-debug and omarchy-debug-idle scripts are installed to /usr/bin by the omarchy-settings package, so the omarchy dispatcher in /usr/share/omarchy/bin cannot route them. Stop advertising 'omarchy debug ...' routes that exit 127 and point users to the working hyphenated form instead. Addresses omacom#7185 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
Withdrawing this workaround. Testing the real router against the packaged layout showed that /usr/bin/omarchy can dispatch debug correctly; the failure depends on invocation through the symlink directory. Hiding the commands globally removes useful discovery without repairing that context, while completion and other shipped instructions still advertise them. The PATH/routing approaches in #7239 and #9290 are a better direction. My original description overstated the failure as universal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy-debugandomarchy-debug-idleare installed to/usr/binby theomarchy-settingspackage, while theomarchydispatcher only searches its own directory. This means theomarchy debugandomarchy debug idleroutes the help system advertises always exit 127.Stop advertising those unreachable routes by marking both scripts
omarchy:hidden=trueand removing theiromarchy:examplesannotations. Also remove thedebuggroup from the top-level help since it has no reachable commands, and correctcontributing.mdto use the working hyphenatedomarchy-debugform.The
SKILL.mdreferences are left as-is because they are currently being rewritten in #6718; that PR should apply the same correction.Addresses #7185.
Test plan
omarchy debug/omarchy debug idleroutes.github/ISSUE_TEMPLATE/bug.ymlalready uses the hyphenatedomarchy-debugform./test/allon a Linux box (not available in this environment)