Fix Hermes desktop launch settings (2026.8.31-3) - #336
Merged
Conversation
Release 2026.8.31-3 preserves upstream desktop settings and explicit launch environment without invoking the CLI sandbox setup. Keep incomplete runtimes from blocking the packaged fallback, and use the namespace sandbox consistently in both locations. Co-Authored-By: Codex XHigh <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hermes Desktop's direct launcher skipped
config.yamldesktop settings, and an inheritedELECTRON_RUN_AS_NODE=1could prevent a window from opening. Use Hermes' own settings parser for Electron flags, GPU policy, password store and Ozone hints, and preserve the launch directory and explicit environment overrides for both menu launches andhermes://links. Clear inherited Electron/Python overrides, preserve that clean environment across upstream imports, and keep the packaged fallback usable when the Python installation is incomplete.Bump the package to 2026.8.31-3. Both the packaged and user-built app use the same user-namespace sandbox check, and
chrome-sandboxis always installed with mode 0755 instead of choosing its permissions from the builder's capabilities. Hosts without working unprivileged user namespaces receive an error; the launcher does not escalate privileges or disable the sandbox.Follow-up to the late review on #335. The package retains its visible, URL-capable desktop entry. Normal launches do not create another entry, but upstream build-only updates still register a separate user entry and offer no opt-out. Omarchy #10613 hides that generated entry through its existing launcher hide list, keeping the package launcher as the single Hermes row in the Apps menu.
🤖 Generated by GPT-6 in T3 Code. Reviewed by Codex XHigh.