Skip to content

honeykrisp: expose VK_AMD_shader_core_properties2 #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuaswarren wants to merge 1 commit into
base: integration/aurora
Choose a base branch
from
+5 −0
Open

honeykrisp: expose VK_AMD_shader_core_properties2 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/relnotes/new_features.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,4 @@ GL_OES_draw_buffers_indexed on etnaviv/HALTI5
GL_OES_EGL_image_external_essl3 on etnaviv/HALTI5
GLES 3.0 on etnaviv/HALTI5
VK_QCOM_rotated_copy_commands on Turnip
VK_AMD_shader_core_properties2 on honeykrisp
4 changes: 4 additions & 0 deletions src/asahi/vulkan/hk_physical_device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ hk_get_device_extensions(const struct agx_device *dev,
.KHR_vulkan_memory_model = true,
.KHR_workgroup_memory_explicit_layout = true,
.KHR_zero_initialize_workgroup_memory = true,
.AMD_shader_core_properties2 = true,

@greptile-apps greptile-apps Bot Nov 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Required parent extension is missing

VK_AMD_shader_core_properties2 requires VK_AMD_shader_core_properties, but Honeykrisp advertises only the former. An app that enables both extensions to meet that requirement gets VK_ERROR_EXTENSION_NOT_PRESENT from vk_device_init. Apps that check dependencies first must skip the new extension instead.

Implement and advertise the required parent extension, including its properties, before exposing this one.

.EXT_4444_formats = true,
.EXT_attachment_feedback_loop_layout = true,
.EXT_blend_operation_advanced = true,
Expand Down Expand Up @@ -1434,6 +1435,9 @@ hk_get_device_properties(const struct agx_device *dev,
.dynamicRenderingLocalReadDepthStencilAttachments = false,
.dynamicRenderingLocalReadMultisampledAttachments = true,

/* VK_AMD_shader_core_properties2 */
.activeComputeUnitCount = agx_get_num_cores(dev),

/* VK_KHR_push_descriptor */
.maxPushDescriptors = HK_MAX_PUSH_DESCRIPTORS,

Expand Down
Loading