Repository navigation
Honeykrisp integration: AGX correctness fixes, VK_KHR_cooperative_matrix, G13G CDM trim - #1
Closed
joshuaswarren wants to merge 10000 commits into
Closed
joshuaswarren wants to merge 10000 commits into
joshuaswarren wants to merge 10000 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honeykrisp integration branch: Apple Silicon (AGX) correctness + coopmat + G13G CDM trim
Brings omacom/mesa to the line the Omarchy M+ team actually runs and measures on M1-class hardware. 43 commits on top of the Sep 12 stock sync. Three parts:
1. Correctness fixes (upstreamable — see the series branch)
agx: keep the mod-32 shift count when fusing ushr+iand into ubfe— wrong-results fix for the shift-then-mask fusionagx: represent the fused shift-then-mask as ubfe, not ubitfield_extractnir: pass FP_MATH_CTRL to the builder generator— the NIR generator bug that affects every Mesa driver, not just AGXagx: correctly rounded fdiv/frcp, faithful log/log2, exact sin/cos reduction+ FTZ handling + the late fdiv loweringA clean 6-patch series with these commits only (no receipts, no perf-only changes) is staged at
joshuaswarren/mesa:upstream/correctnessfor forwarding to gitlab.freedesktop.org.2. VK_KHR_cooperative_matrix for AGX
Enabled by default (opt-out via
AGX_SIMDMAT=0): 16x16x16 and fp16 shapes, hardware 8x8x8 fp32 viasimd_matrix_fmadd32, ISA disassembly support, software lowering outside full subgroups, shader-cache key handling, and the regression tests. This is what mlx-omarchy's cooperative-matrix path needs on M1.3. Per-launch CDM barrier trim — G13G only
Trims the kitchen-sink CDM barrier after each compute launch on t8103 (M1) to the designed bit set: +6.3% ctx1024 decode, pins held 24/24, runtime suite 22 cases / 6,189 assertions green (six interleaved A/B rounds, mlx-omarchy v0.6.0 wheel untouched). Deliberately not enabled on G13X (M1 Max): the port measured +13% short / −3.2% long-context and was reverted — this branch carries that history (
5deac1c8068restores the G13X sink).Validation
repro/commits)Not in this branch
hk/*experiment branches (G13X barrier ports, default-off diagnostic knobs, trig-invariance, agx-wait-batching, etc.) stay unmerged until measured — they are not part of this PRreceipts/evidence commits ride along for team review; they will be stripped before any freedesktop submission