Repository navigation
Conversation
Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
Require matching firmware and compatibility identities on J613/T8122 before enabling preview. Recognize 26.6.2 separately so the existing wide setfile command is selected. Disable still MBNR explicitly and keep temporal history out of the preview path. Preserve H17 and older profiles, including their metadata handling. Test the production firmware parser and admission predicate with malformed identities and board, SoC and opt-in combinations. Capture quality, metadata requirements and suspend remain hardware qualification gates. Signed-off-by: Satya Benson <satya@benson.earth>
Signed-off-by: Satya Benson <satya@benson.earth>
Author
Enable the preview profile by default only when the existing exact board, SoC, firmware and compatibility admission checks pass. Retain preview_26=0 as an opt-out. C13k on J613 with 26.6.2 firmware qualified preview through PipeWire, open/close cycles and suspend. That boot explicitly passed preview_26=1; default selection is covered by the host admission test. Image noise remains a quality follow-up. Signed-off-by: Satya Benson <satya@benson.earth>
satchlj
marked this pull request as ready for review
November 3, 2026 22:55
satchlj
requested review from
chriskearney,
maralcbr and
scottjones
as code owners
November 3, 2026 22:55
Author
|
Claude Fable 5.2 on @satchlj's behalf Closing in favour of aurora-silicon/linux#974, where this change is now maintained against aurora-silicon/linux integration/aurora (still open there). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contain timed-out ISP sessions, preserve host buffer ownership after publication, bound receive turns, validate outstanding buffer returns and notify failed streaming queues. Enable the 26.6.2 preview profile by default only for the exact J613/T8122 board, firmware and compatibility match.
apple_isp.preview_26=0remains an opt-out. The profile selects existing wide-address setfile commands, disables still MBNR and avoids temporal/history startup while retaining public metadata and calibration choices.Hardware qualification: the owner's C13k boot on rubra (M3 Air J613, firmware 26.6.2) exercised working preview through PipeWire, open/close cycles and suspend. That boot explicitly used
apple_isp.preview_26=1; the new default selection and explicit opt-out are covered by the production admission host test. Image noise is a known image-quality follow-up, not a regression introduced by this default-selection change. This evidence is from the combined C13k kernel, not a boot of this exact PR head.Validation of the follow-up: five generic ISP host suites and both preview suites pass in normal and optimized Python. The affected module builds with
W=1through modpost, link and BTF against the prepared C13k build context. This is an affected-module build, not a full integration build. All 22 injected negative-control runs also compiled successfully and rejected the faults in normal and optimized Python. Older/H17 behavior is covered by host tests; hardware regression coverage for those profiles remains separate.Owner-approved default-on follow-up is pushed. Draft/readiness status is left for the owner to change.