Skip to content

Run the game from the sidebar alone - #18

Merged
dhh merged 3 commits into
masterfrom
sidebar-controls
Nov 16, 2026
Merged

dhh merged 3 commits into
masterfrom
sidebar-controls

Conversation

@dhh

@dhh dhh commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Every control now lives in the right sidebar, and the header bar is gone, so the board gets the window's full height.

Top to bottom, the sidebar holds:

  • the name, with the sidebar toggle and ? beside it
  • the piece-set picker, full width, with its menu opening beneath at the same width
  • the match: opponent, the two players, status, move history
  • Undo, then New game and Settings side by side, then the save line

With the sidebar hidden (B), a small button at the board's top-right corner brings it back; before, that toggle lived in the header. Tab still clears everything for a bare board. No shortcut changed.

Verification

  • bin/test passes. The window test now checks that all five controls sit inside the sidebar, that the board is as tall as the window, and that the on-board button restores a hidden sidebar.
  • Looked at offscreen grabs at 1280×850: the sidebar, the open set menu, and the hidden state.
  • Not checked: a narrow or short window (the history list is what shrinks), a light theme, and right-to-left.

Conflicts to expect: #14 (agent opponent) edits the same sidebar lines.

🤖 Generated with Claude Code

The header bar is gone. Its name, piece-set picker, New game, Settings,
sidebar toggle and help now sit in the right sidebar with the match and
its history, so the board has the window's full height. With the sidebar
put away, a small button on the board brings it back.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues remain.

Summary

Moves the game controls into the sidebar and gives the board the window’s full height.

  • The sidebar holds the game controls beside the match details.

No new actionable issues found. Tests and visual checks were not run during this review; the app uses a native Qt window rather than a browser page.

Reviews (3) · Last reviewed commit: "Fit the name to its room in any serif" · Reviewed by Greptile

Comment thread src/Main.qml Resolved
dhh and others added 2 commits November 16, 2026 14:24
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The builders' serif is wider than the one this was sized against, so a
fixed smaller size still cut the name short there.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@dhh
dhh merged commit 85e56c2 into master Nov 16, 2026
2 checks passed
@dhh
dhh deleted the sidebar-controls branch November 16, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant