Repository navigation
Run the game from the sidebar alone - #18
Merged
Merged
Conversation
The header bar is gone. Its name, piece-set picker, New game, Settings, sidebar toggle and help now sit in the right sidebar with the match and its history, so the board has the window's full height. With the sidebar put away, a small button on the board brings it back. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; no actionable issues remain. SummaryMoves the game controls into the sidebar and gives the board the window’s full height.
No new actionable issues found. Tests and visual checks were not run during this review; the app uses a native Qt window rather than a browser page. Reviews (3) · Last reviewed commit: "Fit the name to its room in any serif" · Reviewed by Greptile |
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The builders' serif is wider than the one this was sized against, so a fixed smaller size still cut the name short there. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every control now lives in the right sidebar, and the header bar is gone, so the board gets the window's full height.
Top to bottom, the sidebar holds:
?beside itWith the sidebar hidden (
B), a small button at the board's top-right corner brings it back; before, that toggle lived in the header.Tabstill clears everything for a bare board. No shortcut changed.Verification
bin/testpasses. The window test now checks that all five controls sit inside the sidebar, that the board is as tall as the window, and that the on-board button restores a hidden sidebar.Conflicts to expect: #14 (agent opponent) edits the same sidebar lines.
🤖 Generated with Claude Code