Repository navigation
Open in half the time - #16
Merged
Merged
Conversation
Before the window had anything to draw, the GUI thread sculpted the set one figure after another and computed 98 textures, each twice. A set's figures are now cast side by side on every core, a geometry declared in QML is built once rather than once per property (which also sculpted an Orbital pawn nobody asked for), each surface is computed once, and the scene shares two textures between every square and piece. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR reduces startup work by:
No actionable issues were found. Tests were not run during this review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkmate took 1.5 to 1.9 s to show its first frame, on every launch rather than only the first. Almost all of it was the GUI thread working before the window had anything to draw.
What was slow
SculptGeometryrebuilt in its constructor and again on each of its four properties, so with Moss & Myth selected it first cast Orbital parts for the defaults.What changed
QtConcurrentthe first time one is wanted; Moss & Myth carves its six figures on six threads.componentComplete. One made in code builds on its first setter.Textures (the set's surface and Atelier's pale wood) between all squares and pieces.Measured
Launch to first full frame on a Radeon 8060S, cold shader and QML caches, isolated save:
Time before the window gets a render context went from 0.89–1.52 s to 0.22 s. What remains is the first frame itself (0.33–0.53 s), which I did not profile; shader compilation, the light probe and supersampling are the likely parts.
bin/testpasses. I compared the four sets' look only through the existing tests, not side by side by eye; the shared textures hold the same data as before.🤖 Generated with Claude Code