Repository navigation
Bring every board to life - #10
Merged
Merged
Conversation
The woodland figures breathe and sway on a shared clock, and now and then one glances aside or skips. A picked figure starts, stretches and shakes its head while its neighbours turn to look. Moves are leaps: a crouch, an arc that leans into the journey and grows with distance, and a sprung landing. A captured figure waits for its captor, then twirls away. The other sets move as before, and reduced motion stills all of it. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; all three previous findings are addressed. SummaryGives each piece set its own idle, pickup, travel, and capture motion.
All three previous findings are addressed. No new actionable issues were found. Reviews (3) · Last reviewed commit: "Settle interrupted poses and time captur..." · Reviewed by Greptile |
The woodland animation is now a table of motion parameters per set, so each board is alive in character. Orbital craft hover with pulsing lights, bank into a glide, dip on arrival and scan when chosen. Midnight Atelier's pieces are handled under a flickering flame: tilted in the fingers, carried over, set down with a rock, and tipped over when taken. Candy Kingdom's sweets wobble like jelly, warm in the hand and pop. One journey animation replaces the old hop, with distance setting its length and height, and captures everywhere wait for the captor. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
A move made during the pick-up shake left the piece turned, and a pick-up during a skip could leave it floating; the journey now straightens the head and the pick-up lands the skip. A captured piece waits for the length of its captor's journey rather than a fixed 240 ms, so a long capture no longer empties the square before anyone arrives. Changing sets starts the new one from rest. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each set now moves in its own manner, driven by one table of motion parameters per set in
ChessPiece.qml.In every set, longer moves take longer and arc higher, knights jump highest, captured pieces wait for their captor, and the target markers pulse.
Reduced motion stills all of it. The clock pauses while the window is inactive.
Things to know
moveHop, so the three original sets no longer use a fixed 360 ms slide.placeproperty, so a journey's distance is measured before the slide starts.Testing
bin/testpasses. The window test now picks up, moves and captures in each of the four sets, and checks that reduced motion cuts a journey short. I checked poses in frames grabbed from the offscreen window; software rendering is too slow to judge how the motion feels, so that needs a look on real hardware.🤖 Generated with Claude Code