Warn about multiple IFactAttribute attributes#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new analyzer to the
Xunit.v3.IntegrationTesting.Analyzersproject that enforces correct usage of dependency attributes on test methods. It ensures that methods do not have multiple dependency attributes or mix dependency attributes with standard fact/theory attributes. The changes include the implementation of the analyzer, its diagnostic descriptors, comprehensive tests, and updates to the analyzer release notes.Analyzer implementation and diagnostics:
MultipleDependsOnAttributeAnalyzerto detect and report when a test method has more than one attribute derived fromDependsOnAttributeBase(e.g., both[FactDependsOn]and[TheoryDependsOn]) or when a dependency attribute is combined with anotherIFactAttribute(e.g.,[Fact]or[Theory]).XIT0015("Method has multiple DependsOn attributes") andXIT0016("Method has DependsOn attribute combined with another IFactAttribute") inAttributeUsageDescriptors.AnalyzerReleases.Unshipped.mdto document the new diagnostics.Testing:
MultipleDependsOnAttributeAnalyzerTests, covering scenarios with multiple dependency attributes, mixing with standard fact/theory attributes, and valid attribute usage.Development tooling:
.vscode/settings.jsonto auto-approvedotnet testcommands for improved developer experience.Fixes #23