Analyzers to secure [DependsOnClasses] attribute#26
Merged
Conversation
…nTesting into users/olstakh/new-analyzer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new analyzer,
AttributeUsageDependsOnClassesAnalyzer, to the codebase. The analyzer enforces correct usage of the[DependsOnClasses]attribute by ensuring that dependency types are properly associated with test collections. It reports diagnostics when a dependency already belongs to a collection or when a dependency is not part of any named collection in certain scenarios. The pull request also adds corresponding diagnostic descriptors, updates the analyzer release notes, and provides comprehensive tests for the new analyzer.Analyzer implementation:
AttributeUsageDependsOnClassesAnalyzerthat reports:[DependsOnClasses]already belongs to a collection (via[Collection]or[CollectionDefinition]), suggesting to use[DependsOnCollections]instead.CollectionBehavior.CollectionPerAssembly, suggesting to add[DependsOnClasses(Name = "...")]to the dependency.Diagnostic descriptors and documentation:
XIT0013andXIT0014toAttributeUsageDescriptorsfor the analyzer's warnings.AnalyzerReleases.Unshipped.md.Testing:
AttributeUsageDependsOnClassesAnalyzerTestscovering all relevant scenarios for the new analyzer, including both positive and negative cases.