Skip to content

Repo maintenance#22

Merged
olstakh merged 8 commits intomainfrom
users/olstakh/small-updates
Mar 31, 2026
Merged

Repo maintenance#22
olstakh merged 8 commits intomainfrom
users/olstakh/small-updates

Conversation

@olstakh
Copy link
Copy Markdown
Owner

@olstakh olstakh commented Mar 30, 2026

This pull request primarily updates documentation for clarity and simplifies the codebase by removing unnecessary using directives and refactoring logic. It also makes a key change to how test collection dependency cycles are handled, improving test execution robustness. The most important changes are:

Documentation improvements:

  • Clarified the description of [FactDependsOn] in the README.md, emphasizing its skip logic for upstream dependencies. Also improved the FAQ to explain when and why to use [FactDependsOn] instead of [Fact], and how dependency-aware skipping works. [1] [2]

Codebase simplification and cleanup:

Test collection dependency handling:

  • Changed the behavior in DependencyAwareTestCollectionOrderer so that if a circular dependency is detected, the original test collection order is preserved and tests are allowed to run, instead of throwing an exception and aborting execution. This makes test runs more resilient in the presence of misconfigured dependencies.

Test case comparison logic:

  • Refactored TestCaseComparer to use the UniqueID property for equality and hash code computation, simplifying and improving the reliability of test case comparisons.

Dependency skipping logic:

  • Refactored DependencySkippingAssemblyRunner to use SkipValidator.ShouldSkipBasedOnCollectionDependencies for deciding when to skip a test collection, and removed the now-redundant internal logic. [1] [2]

@olstakh olstakh merged commit 89a9ae6 into main Mar 31, 2026
2 checks passed
@olstakh olstakh deleted the users/olstakh/small-updates branch March 31, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant