Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily updates documentation for clarity and simplifies the codebase by removing unnecessary using directives and refactoring logic. It also makes a key change to how test collection dependency cycles are handled, improving test execution robustness. The most important changes are:
Documentation improvements:
[FactDependsOn]in theREADME.md, emphasizing its skip logic for upstream dependencies. Also improved the FAQ to explain when and why to use[FactDependsOn]instead of[Fact], and how dependency-aware skipping works. [1] [2]Codebase simplification and cleanup:
usingdirectives from multiple files in both the analyzers and test projects, reducing clutter and potential confusion. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]Test collection dependency handling:
DependencyAwareTestCollectionOrdererso that if a circular dependency is detected, the original test collection order is preserved and tests are allowed to run, instead of throwing an exception and aborting execution. This makes test runs more resilient in the presence of misconfigured dependencies.Test case comparison logic:
TestCaseComparerto use theUniqueIDproperty for equality and hash code computation, simplifying and improving the reliability of test case comparisons.Dependency skipping logic:
DependencySkippingAssemblyRunnerto useSkipValidator.ShouldSkipBasedOnCollectionDependenciesfor deciding when to skip a test collection, and removed the now-redundant internal logic. [1] [2]