Repository navigation
Fix: Keep the active hint below dropdown menus #125 - #124
Merged
Merged
Conversation
Move the border z-order bookkeeping out of restack() into stack_border_above_window(). No behavior change.
Some Wayland popups, such as Firefox menus, do not take a seat grab. Mutter therefore does not focus and raise them above the foreign hint actor, leaving the hint drawn on top of the popup. The existing window_created restack can run before the popup actor is in the window stack. Re-stack the focused hint from display::restacked, after Mutter has finished ordering. GTK menus take a seat grab and are raised above the hint, so they are unaffected. Focused window only; overlay-all is unchanged.
benleppke
marked this pull request as ready for review
October 27, 2026 22:56
Contributor
Author
|
Looks like #113 touches the same |
oliwebd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some Wayland popups (such as Firefox dropdown menus) do not take a seat grab. Because of this Mutter does not focus them or raise them above the active hint, causing the hint to render on top of the popup.
You can reproduce this by launching a native Wayland window (not XWayland) such as Firefox and opening a dropdown menu that extends beyond the window border.
Fix
An adjustment to how window layers are ordered so that borders are correctly placed on top:
stack_border_above_window()restackedsignal (Meta.Display::restacked) that triggersreassert_focused_hint_stack().This ensures borders re-apply their correct stacking position (staying above the window and below popups) when the window manager rearranges layers.
Testing was done with v2.12.01 on Fedora44/GNOME 50.6
Closes #125