Skip to content

Update dependencies and add donation links - #109

Merged
olemarkus merged 1 commit into
mainfrom
chore/update-dependencies
Nov 5, 2026
Merged

olemarkus merged 1 commit into
mainfrom
chore/update-dependencies

Conversation

@olemarkus

Copy link
Copy Markdown
Owner

Update supported dependencies, including Vitest 5 and Homey SDK types 1.8, and align Node types with the Node 22 runtime. Retain TypeScript 6 because typescript-eslint does not support TypeScript 7 yet. Rename the Homey import binding to satisfy lint against the new SDK types without changing runtime behavior.

Add PayPal donation metadata and GitHub funding links matching Waterguard.

Validation: npm run validate passed, including 419 tests, coverage thresholds, lint, typechecking, and Homey publish validation. Production audit is clean. Development tooling retains 11 moderate minimatch findings and one high image-size finding; their upstream consumers do not yet support patched versions.

Upgrade supported dependencies, including Vitest 5 and Homey SDK types, and align Node types with the Node 22 runtime. Rename Homey imports to avoid new SDK type lint warnings.

Add PayPal donation metadata and GitHub funding links. Retain TypeScript 6 until the lint toolchain supports TypeScript 7.
Copilot AI balanced review requested due to automatic review settings November 5, 2026 21:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change adds GitHub and PayPal funding details, updates Homey class references to use HomeySDK, and updates runtime and development dependency versions.

Changes: Funding metadata

Layer / File(s) Summary
Funding entries
.github/FUNDING.yml, .homeycompose/app.json, app.json
The funding configuration adds GitHub and PayPal links. The app metadata adds a PayPal contribution entry with username olemwith.

Homey SDK updates

Layer / File(s) Summary
SDK dependency declarations
package.json
The dependency declarations update the @types/homey alias and versions for pino and several development packages.
SDK class references
app.ts, drivers/nordic-cloud/driver.ts, drivers/nordic/driver.ts, lib/FlexitNordicBaseDevice.ts
The app, drivers, and base device import Homey as HomeySDK and reference its App, Driver, or Device class.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 80a4c

No actionable merge-blocking issue is established. The funding additions and SDK reference updates appear mergeable subject to normal validation.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title "Update dependencies and add donation links" matches the main changes. The PR updates dependencies, including Vitest 5, Homey SDK types 1.8, pino, and @types/node. It also adds PayPal donati…
Description check Passed The description states the dependency updates (Vitest 5, Homey SDK types 1.8, Node 22 types, TypeScript 6 retained) and the Homey import binding rename. It also covers the PayPal donation metadata and…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Update dependencies and add donation links" matches the main changes. The PR updates dependencies, including Vitest 5, Homey SDK types 1.8, pino, and @types/node. It also adds PayPal donation metadata and GitHub funding links in .github/FUNDING.yml, .homeycompose/app.json, and app.json. The title is concise and specific, and it describes both parts of the changeset.

Full details: Description check

Explanation

The description states the dependency updates (Vitest 5, Homey SDK types 1.8, Node 22 types, TypeScript 6 retained) and the Homey import binding rename. It also covers the PayPal donation metadata and GitHub funding links. The validation notes and audit findings relate to the package changes. The description is directly related to the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 4 files. (4 skipped: 4 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

app.ts

Parsing error: Unable to parse the specified 'tsconfig' file. Ensure it's correct and has valid syntax.

tsconfig.json(2,14): error TS6053: File '@tsconfig/node22/tsconfig.json' not found.

drivers/nordic-cloud/driver.ts

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

drivers/nordic/driver.ts

ESLint skipped: the matched ESLint configuration already failed (missing-dependency).

  • 2 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the funding page,
Then hops through types from page to page.
GitHub and PayPal join the list,
While SDK names are changed and fixed.
The bunny nods, then bounds away.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c1b4ff3-c010-466f-926d-1bf7ab6ac20a
Commits

Reviewing files that changed from the base of the PR and between db48f42 and 80a4cb7.

Files ignored due to path filters: 1

  • package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 8

  • .github/FUNDING.yml
  • .homeycompose/app.json
  • app.json
  • app.ts
  • drivers/nordic-cloud/driver.ts
  • drivers/nordic/driver.ts
  • lib/FlexitNordicBaseDevice.ts
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@olemarkus

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@olemarkus
olemarkus merged commit bfeff8e into main Nov 5, 2026
6 checks passed
@olemarkus olemarkus mentioned this pull request Nov 5, 2026
@olemarkus
olemarkus deleted the chore/update-dependencies branch November 5, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants