Conversation
Replaced `filepath.ToSlash` with `strings.ReplaceAll` for Windows path normalization in `resolveInBundle` and `resolveBundleDir` to fix path traversal boundaries on POSIX systems. Added `getStringArg` helper in `mcp.go` to enforce validation, type-checking, and bounds limitations (1KB constraints, 1MB body limit) on strings for MCP tool inputs. Added negative tests to `mcp_test.go` and `mutate_security_test.go` to verify these boundary constraints and malicious inputs rejection. Co-authored-by: sknr <11868275+sknr@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaced
filepath.ToSlashwithstrings.ReplaceAllfor Windows path normalization inresolveInBundleandresolveBundleDirto fix path traversal boundaries on POSIX systems. AddedgetStringArghelper inmcp.goto enforce validation, type-checking, and bounds limitations (1KB constraints, 1MB body limit) on strings for MCP tool inputs. Added negative tests tomcp_test.goandmutate_security_test.goto verify these boundary constraints and malicious inputs rejection.PR created automatically by Jules for task 16583702038588133826 started by @sknr