Skip to content

fix(security): harden path boundaries and sanitize mcp inputs - #33

Closed
sknr wants to merge 1 commit into
developfrom
fix-mcp-validation-16583702038588133826
Closed

sknr wants to merge 1 commit into
developfrom
fix-mcp-validation-16583702038588133826

Conversation

@sknr

@sknr sknr commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Replaced filepath.ToSlash with strings.ReplaceAll for Windows path normalization in resolveInBundle and resolveBundleDir to fix path traversal boundaries on POSIX systems. Added getStringArg helper in mcp.go to enforce validation, type-checking, and bounds limitations (1KB constraints, 1MB body limit) on strings for MCP tool inputs. Added negative tests to mcp_test.go and mutate_security_test.go to verify these boundary constraints and malicious inputs rejection.


PR created automatically by Jules for task 16583702038588133826 started by @sknr

Replaced `filepath.ToSlash` with `strings.ReplaceAll` for Windows path normalization in `resolveInBundle` and `resolveBundleDir` to fix path traversal boundaries on POSIX systems. Added `getStringArg` helper in `mcp.go` to enforce validation, type-checking, and bounds limitations (1KB constraints, 1MB body limit) on strings for MCP tool inputs. Added negative tests to `mcp_test.go` and `mutate_security_test.go` to verify these boundary constraints and malicious inputs rejection.

Co-authored-by: sknr <11868275+sknr@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@sknr

sknr commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Superseded and completed on develop via commits 809f521, 41682b4, 05b6fc5, a7d0bbe, 1647508, and b3758c5.

@sknr sknr closed this Sep 19, 2026
@sknr
sknr deleted the fix-mcp-validation-16583702038588133826 branch September 19, 2026 13:05
@google-labs-jules

Copy link
Copy Markdown
Contributor

Superseded and completed on develop via commits 809f521, 41682b4, 05b6fc5, a7d0bbe, 1647508, and b3758c5.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant