Skip to content

fix: Show empty days in Work Log weekly view#24

Merged
okaryo merged 1 commit into
mainfrom
fix/log-range
Jun 2, 2026
Merged

fix: Show empty days in Work Log weekly view#24
okaryo merged 1 commit into
mainfrom
fix/log-range

Conversation

@okaryo
Copy link
Copy Markdown
Owner

@okaryo okaryo commented Jun 2, 2026

Summary

  • Show the latest 7 local calendar days in the Work Log section
  • Display No log for days without entries
  • Add tests for recent Work Log day grouping

Checks

  • pnpm run format:check
  • pnpm run lint
  • pnpm run check
  • pnpm test
  • pnpm run build

@okaryo okaryo self-assigned this Jun 2, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce30a93f2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +64 to +70
const visibleWorkLogGroups = $derived(
buildRecentWorkLogGroups(
workLogs,
relativeTimeNowMs,
RECENT_WORK_LOG_DAY_COUNT,
),
);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep keyboard selection within visible recent logs

Because the rendered list is now derived from the moving seven-day window while workLogs itself is never pruned or reloaded as relativeTimeNowMs advances, leaving the app open across midnight can drop the previously selected oldest-day log from these groups while selectedWorkLogId still points at it. In that state the UI shows no selected row, and keyboard edit/navigation can continue to target an invisible log from outside the displayed week; the selection should be reconciled against the visible groups/logs when this derived window changes.

Useful? React with 👍 / 👎.

@okaryo okaryo merged commit 5c5425d into main Jun 2, 2026
2 checks passed
@okaryo okaryo deleted the fix/log-range branch June 2, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant