remove dependency to symfony/symfony - #11
Open
Metabor wants to merge 8 commits into
Open
Conversation
Libraries should not depend on metapackage symfony/symfony, but on the Symfony components they use. See https://symfony.com/doc/current/setup/flex.html#upgrading-existing-applications-to-flex
Contributor
Author
|
Also needed to switch to PHPUnit as a dev dependency to prevent this error: |
Contributor
Author
|
Tests are fixed now. With the changes above this bundle can be used with symfony flex (and maybe it is also Symfony 4 compatible now, but I didn't checked it). |
|
@Metabor I can confirm that's working on Symfony 4 :) Thx for the work :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libraries should not depend on metapackage symfony/symfony, but on the Symfony components they use.
See https://symfony.com/doc/current/setup/flex.html#upgrading-existing-applications-to-flex