Skip to content

remove dependency to symfony/symfony - #11

Open
Metabor wants to merge 8 commits into
okapon:masterfrom
Metabor:patch-3
Open

remove dependency to symfony/symfony#11
Metabor wants to merge 8 commits into
okapon:masterfrom
Metabor:patch-3

Conversation

@Metabor

@Metabor Metabor commented May 17, 2018

Copy link
Copy Markdown
Contributor

Libraries should not depend on metapackage symfony/symfony, but on the Symfony components they use.
See https://symfony.com/doc/current/setup/flex.html#upgrading-existing-applications-to-flex

@Metabor

Metabor commented May 17, 2018

Copy link
Copy Markdown
Contributor Author

Also needed to switch to PHPUnit as a dev dependency to prevent this error:
https://stackoverflow.com/questions/49833939/php-fatal-error-parserparsefile-symfony-3-4-travis-ci

@Metabor

Metabor commented May 17, 2018

Copy link
Copy Markdown
Contributor Author

Tests are fixed now. With the changes above this bundle can be used with symfony flex (and maybe it is also Symfony 4 compatible now, but I didn't checked it).

@PastisD

PastisD commented Aug 25, 2018

Copy link
Copy Markdown

@Metabor I can confirm that's working on Symfony 4 :)
Just had to change the compatibility in composer.yml (PastisD@6b46d87 We can even let the ~2.6 dependency)

Thx for the work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants