fix(iOS): don't fail tag discovery when readNDEF errors on blank tags#268
Open
harSofja wants to merge 1 commit into
Open
fix(iOS): don't fail tag discovery when readNDEF errors on blank tags#268harSofja wants to merge 1 commit into
harSofja wants to merge 1 commit into
Conversation
Blank/unformatted NTAG213 tags pass queryNDEFStatus with .readWrite but fail readNDEF (e.g. zero-length message). The previous guard only suppressed error 403, so blank tags caused completionHandler(nil, error) and onDiscovered never fired in Flutter. Now any readNDEF error returns the pigeon without a cached message, keeping the tag discoverable and writable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Blank/unformatted NTAG213 tags pass queryNDEFStatus with .readWrite but fail readNDEF (e.g. zero-length message). The previous guard only suppressed error 403, so blank tags caused completionHandler(nil, error) and onDiscovered never fired in Flutter. Now any readNDEF error returns the pigeon without a cached message, keeping the tag discoverable and writable.
Fix
When
readNDEFfails for any reason, returncompletionHandler(pigeon, nil)instead of propagating the error. The
pigeonalready contains the correctNDEF status and capacity from
queryNDEFStatus, so Flutter can discover thetag and the app can proceed to write NDEF records normally.
This mirrors how
.notSupportedstatus is handled, we never fail the wholediscovery, we just omit the cached message.
Tested on