Fix Immunization dates: use the bare occurrence path in the ViewDefinition (fixes #71) - #72
Open
dhes wants to merge 1 commit into
Open
Fix Immunization dates: use the bare occurrence path in the ViewDefinition (fixes #71)#72dhes wants to merge 1 commit into
occurrence path in the ViewDefinition (fixes #71)#72dhes wants to merge 1 commit into
Conversation
The ViewDefinition used the choice-shorthand path `occurrenceDateTime`, which kotlin-fhirpath evaluates to empty (accessors resolve only the bare `occurrence` element), so dates never rendered. Use `occurrence`. Also sort the section newest-first via the ISO-8601 string form. Reported as ohs-foundation#71. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LGgxE9TK56BNPJJX2PnYhj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Immunization ViewDefinition's date column used the choice-shorthand path
occurrenceDateTime, which kotlin-fhirpath evaluates to empty — its accessors resolve only the bareoccurrenceelement (and per the FHIRPath spec, choice elements are addressed by their base name, withofType()for type selection). As a result immunization dates never rendered anywhere in the app. This changes the path tooccurrence(one word) and, since dates now exist, sorts the section newest-first — ISO-8601 string ordering, undated entries sink to the bottom.Testing
:reference-app:jvmTestgreen.Fixes #71.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LGgxE9TK56BNPJJX2PnYhj