Fix erroneously detecting gum as present when it's not.

[ikogan]

No description provided.

[Copilot]

Pull request overview

This PR aims to prevent the script from incorrectly treating gum as installed/usable when it isn’t, and includes a small fix to the checksum-download logging path.

Changes:

• Fix an info call that was accidentally passing -e as an argument.
• Change the gum installation decision to use a runtime check (gum -v) instead of should_install "gum".

Suppressed comments (1)

adp-connect.sh:759

• This install guard uses gum -v (runtime check), but earlier HAVE_GUM is initialized via which gum (line 2) and is used before this block (e.g., confirm() at ~739). If which reports a gum shim/alias/function (not an actual working gum binary), the script will try to run gum confirm before reaching this installation block and fail, so this change may not fully address the “gum present when it’s not” scenario.

Consider making HAVE_GUM reflect an executable gum (e.g., using type -P gum and/or gum --version), and/or moving the gum install/validation earlier so any gum-dependent UI paths can’t execute until gum is known-good.

if [[ -n "${FORCE_UPDATE}" ]] || ! gum -v &>/dev/null; then
    download_latest_release "charmbracelet/gum" "gum" "tar.gz" || exit 1
    extract_download "gum" "tar.gz" || exit 1
    install -m "0755" "${TEMP_DIR}/gum"*/"gum" "$HOME/.local/bin/gum" || exit 1
    info "🎉 Successfully installed gum!"

    HAVE_GUM="true"
fi

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.