Phase 3a: add a pre-commit standard to core:setup-repo - #14
Open
jonnyspicer wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pre-commit standard to
core:setup-repofor the Python and TS stacks, with CI as the single source of truth — lint/format/hygiene are defined once in.pre-commit-config.yamland run both locally (git hook) and in CI. First half of Phase 3; the C++/CMake stack (Phase 3b) is a separate later sub-project.What's added
assets/precommit/):python.yaml(hygiene hooks +astral-sh/ruff-pre-commit:ruff --fix,ruff-format) andts.yaml(hygiene hooks + a localnpx eslint --fixhook). Both pinpre-commit-hooks@v5.0.0; python pinsruff-pre-commit@v0.8.0.ci-python.ymlandci-node.ymlnow runuvx pre-commit run --all-filesfor lint/format/hygiene (the directruff check/ruff formatandnpm run lintsteps are removed). Tests (pytest / typecheck + test) stay. The node CI gains a Python+uv step so it can run pre-commit..pre-commit-config.yamlfor python/ts stacks (notnone).uvx pre-commit install); CLAUDE.md guidance now points atpre-commit run --all-filesas the lint/format command.0.4.0 → 0.5.0.test-precommit-assets.sh(wired into this repo's CI) + updated CI/scaffold tests.Out of scope: C++ (Phase 3b), prettier, typecheck-on-commit.
Verification
test-precommit-assets,test-python-assets,test-ci-assets,test-node-assets,test-scaffold) andclaude plugin validate .passes.pre-commit run --all-fileson freshly scaffolded temp repos: python (rc=0; hygiene passed, ruff skipped — no.pyin the base scaffold) and ts-frontend (rc=0 afternpm install; hygiene + eslint passed).Process
Subagent-driven: fresh implementer per task, per-task spec+quality review with fixes, Opus whole-branch review (verdict: ready to merge). The validator was hardened to pin the hook revs,
ruff --fix, and the eslint hook fields.🤖 Generated with Claude Code